fix: Install the protobuf compiler in release CI #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out we'd forgotten to update the cargo-dist configuration to install the protobuf compiler for our release builds in CI. This commit _should_ fix it, though I'm not able to test it until it's deployed and I try to cut a new release. The basic idea here is that cargo-dist provides configuration items to use platform-specific package managers to install needed packages. In our case, funnily enough, the protobuf compiler package has a different name on every platform. For the moment I am not tying us to a specific version, just using the `*` to indicate we should always be using latest. If that becomes an issue in the future we can tighten it up. Signed-off-by: Andrew Lilley Brinker <[email protected]>
mchernicoff
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we'd forgotten to update the cargo-dist configuration to install the protobuf compiler for our release builds in CI. This commit should fix it, though I'm not able to test it until it's deployed and I try to cut a new release.
The basic idea here is that cargo-dist provides configuration items to use platform-specific package managers to install needed packages. In our case, funnily enough, the protobuf compiler package has a different name on every platform.
For the moment I am not tying us to a specific version, just using the
*to indicate we should always be using latest. If that becomes an issue in the future we can tighten it up.