feat: Add JSON Pointer preprocessor for Policy Expression language #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit augments the Policy Expression language by allowing use of values from a JSON `context` variable in Policy expressions. It adds a preprocessing step before parsing and evaluation of expressions where JSON pointers are parsed and looked up.
cstepanian
force-pushed
the
cstepanian/json_pointer
branch
from
ecfec22 to
6c1825c
Compare
alilleybrinker
approved these changes
Sep 5, 2024
|
Thanks @cstepanian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #261
This PR adds a JSON Pointer preprocessor step before parsing and evaluation of Policy Expressions.
It adds a
contextparameter to the execution of Policy Expressions, which is used to lookup values referred to by the JSON Pointers.It allows a limited subset of the full JSON Pointer syntax: only alphanumeric, '/' (slash), '~' (tilde), and '_' (underscore) characters are allowed.
This PR also adds a
MultipleErrorsvariant ofpolicy_exprs::error::Error. It is probably not the best long term design to solve the problem of tracking a list of errors found during parsing, checking, and execution of a language.