chore: Remove unused version handling #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
added
the
type: refactor
alilleybrinker
requested review from
cstepanian
and removed request for
a team
Previously (before open sourcing Hipcheck) we'd update the `Cargo.toml` file for the Hipcheck crate after releasing a new version to reflect that we're now working on a pre-release of the _next_ version, and we had special handling in Hipcheck itself to identify at build time when we were building one of these pre-release versions and add the commit hash of the repository itself to Hipcheck's version. This was cool, and the idea was to make it obvious when you were running a pre-release build of Hipcheck and _which_ pre-release build you were running. However, when we transitioned to open source, we changed how releases happen, and stopped doing the pre-release marking, which means this special handling code hadn't been used at all since then. What's more, it's an extra piece of complexity that we've been carrying around. Rather than try to once again change our release flow, I'm removing the special handling code since it's unused. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/remove-unused-version
branch
from
99d46c4 to
44fa253
Compare
alilleybrinker
requested review from
mchernicoff
and removed request for
cstepanian
mchernicoff
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #311, merge that first then rebase this.Ready for review!
Previously (before open sourcing Hipcheck) we'd update the
Cargo.tomlfile for the Hipcheck crate after releasing a new version to reflect that
we're now working on a pre-release of the next version, and we had special
handling in Hipcheck itself to identify at build time when we were building
one of these pre-release versions and add the commit hash of the repository
itself to Hipcheck's version. This was cool, and the idea was to make it
obvious when you were running a pre-release build of Hipcheck and which
pre-release build you were running.
However, when we transitioned to open source, we changed how releases
happen, and stopped doing the pre-release marking, which means this special
handling code hadn't been used at all since then. What's more, it's an extra
piece of complexity that we've been carrying around. Rather than try to
once again change our release flow, I'm removing the special handling code
since it's unused.