Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): remove use of Source, SourceRepo, Remote structs #229

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

j-lanson
Copy link
Collaborator

This PR mostly finishes the effort of phasing out the old structs for representing the target of a HipCheck analysis (i.e. Source, SourceRepo, Remote, etc.).

In a future PR we may want to remove the source module and rename the SourceQuery salsa database to completely remove use of the word "source" where we mean "target", but I thought I would avoid moving files around in this one and focus on deletion/replacment.

@j-lanson j-lanson requested review from vcfxb and mchernicoff July 25, 2024 13:41
@j-lanson j-lanson self-assigned this Jul 25, 2024
@j-lanson j-lanson added the type: chore Clean up or management task. label Jul 25, 2024
@mchernicoff mchernicoff merged commit 724ad93 into main Jul 25, 2024
9 checks passed
@j-lanson j-lanson deleted the jlanson/target-replaces-source branch July 31, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Clean up or management task.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants