feat: add more robust 'target resolution' system #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
requested changes
Jul 24, 2024
|
Just the one small nitpick, otherwise this LGTM! Ping me when it's ready for re-review. |
mchernicoff
force-pushed
the
feature/target-type-refactor-squashed
branch
from
af42680 to
4eb2b58
Compare
|
@alilleybrinker I deleted the commented out code. Ready for re-review. |
alilleybrinker
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need for the refactor represented by this PR was determined from discussions around tackling #183 .
This PR was a collaborative effort between myself and @mchernicoff .
This PR uses the types defined in
target/types.rsfor representing the "target" of a HipCheck analysis. Although information can be specified on the cmdline by users in a variety of ways (variants ofTargetSeed), we eventually need to arrive at a local clone of a git repository that may or may not have an associated remote repo / package information. This is all encapsulated by theTargetstruct.This PR provides glue code for converting
cli.rsstructures toTargetSeedinstances using theToTargetSeedtrait. Theresolve_target()function does the work ofTargetSeedtoResult<Target>translation.In order to limit the LOC changed by this PR, the generated
Targetis then translated to the existingSourceobject insource/query.rs. In a future PR we will do the work of removing theSourceecosystem and fully replacing it withTarget.