Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asff_mapper and prowler_mapper #104

Merged
merged 20 commits into from
Aug 11, 2021
Merged

asff_mapper and prowler_mapper #104

merged 20 commits into from
Aug 11, 2021

Conversation

Amndeep7
Copy link
Contributor

No description provided.

@Amndeep7 Amndeep7 marked this pull request as draft June 22, 2021 23:53
@Amndeep7 Amndeep7 requested review from rx294, rbclark and Bialogs July 12, 2021 18:01
@Bialogs
Copy link
Contributor

Bialogs commented Jul 13, 2021

@Amndeep7 is this ready for review even though it is in draft?

@Amndeep7
Copy link
Contributor Author

@Bialogs I still need to flesh out the documentation, use aaron's account to make test data, and make a minor change to the prowler mapper, but otherwise yes for this portion. If we want to include the aws sdk mapper in this pr as well, then we can hold off until that's implemented, but that'll be sometime next week before I can work it.

@ejaronne ^

@Amndeep7 Amndeep7 changed the title WIP: asff_mapper asff_mapper and prowler_mapper Aug 5, 2021
@Amndeep7 Amndeep7 marked this pull request as ready for review August 5, 2021 04:35
@Amndeep7
Copy link
Contributor Author

Amndeep7 commented Aug 5, 2021

This force push was to rebase on top of master

Amndeep7 added 11 commits August 5, 2021 01:02
Signed-off-by: Amndeep Singh Mann <[email protected]>
…ile not just individual finding

Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
…ting 'informational' to 'medium'.

Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
Copy link
Contributor Author

Amndeep7 commented Aug 5, 2021

And this force push is to do all the signoffs that I never remember to do

@rx294
Copy link
Contributor

rx294 commented Aug 6, 2021

The automated tests are failing on ruby 2.5, coz of the difference method.

@Amndeep7
Copy link
Contributor Author

Amndeep7 commented Aug 9, 2021

The automated tests are failing on ruby 2.5, coz of the difference method.

Feels bad man. Thanks for figuring that out for me. I'll try to find a different method to use / write it myself.

…handle the 'no_status' value as per review

Signed-off-by: Amndeep Singh Mann <[email protected]>
…st have a larger sample on the whole as per review

Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
Copy link
Contributor Author

Amndeep7 commented Aug 9, 2021

Life is suffering. Now it seems like the hash type doesn't support filter in 2.5

@Amndeep7 Amndeep7 marked this pull request as draft August 9, 2021 23:15
@Amndeep7
Copy link
Contributor Author

Amndeep7 commented Aug 9, 2021

Working with Ryan made me realize there was an issue in the nist_tag code. Will fix tonight.

@Amndeep7 Amndeep7 marked this pull request as ready for review August 10, 2021 03:51
@rx294
Copy link
Contributor

rx294 commented Aug 11, 2021

LGTM, thank you for making the updates.
Merging.

@rx294 rx294 merged commit 4d00608 into master Aug 11, 2021
@rx294 rx294 deleted the asff_mapper branch August 11, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants