-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asff_mapper and prowler_mapper #104
Conversation
@Amndeep7 is this ready for review even though it is in draft? |
@Bialogs I still need to flesh out the documentation, use aaron's account to make test data, and make a minor change to the prowler mapper, but otherwise yes for this portion. If we want to include the aws sdk mapper in this pr as well, then we can hold off until that's implemented, but that'll be sometime next week before I can work it. |
This force push was to rebase on top of master |
Signed-off-by: Amndeep Singh Mann <[email protected]>
…ile not just individual finding Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
…ting 'informational' to 'medium'. Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
And this force push is to do all the signoffs that I never remember to do |
The automated tests are failing on ruby 2.5, coz of the difference method. |
Feels bad man. Thanks for figuring that out for me. I'll try to find a different method to use / write it myself. |
…handle the 'no_status' value as per review Signed-off-by: Amndeep Singh Mann <[email protected]>
…st have a larger sample on the whole as per review Signed-off-by: Amndeep Singh Mann <[email protected]>
Life is suffering. Now it seems like the hash type doesn't support |
…instead. Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Working with Ryan made me realize there was an issue in the nist_tag code. Will fix tonight. |
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
LGTM, thank you for making the updates. |
No description provided.