Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields to Nessus STIG compliance mapper #101

Closed
ejaronne opened this issue Jun 3, 2021 · 6 comments · Fixed by #102
Closed

Add fields to Nessus STIG compliance mapper #101

ejaronne opened this issue Jun 3, 2021 · 6 comments · Fixed by #102
Assignees
Labels
bug Something isn't working

Comments

@ejaronne
Copy link
Contributor

ejaronne commented Jun 3, 2021

Add the following HDF tags to output:

  • rid (parsed from Nessus' Rule-ID)
  • CCI (array from Nessus' CCI)
  • Stig_id (from Neuss' STIG-ID)

These are crucial to allow inspec2ckl to form proper .ckl files

Example data to parse in a .nessus xml:

cm:compliance-reference800-171|3.13.8,800-53|SC-8,800-53|SC-8(1),CAT|II,CCI|CCI-002418,CCI|CCI-002421,CN-L3|8.1.2.2(a),CN-L3|8.1.2.2(b),CN-L3|8.1.4.7(a),CN-L3|8.1.4.8(a),CN-L3|8.2.4.5(c),CN-L3|8.2.4.5(d),CN-L3|8.5.2.2,CSCv6|13,CSF|PR.DS-2,CSF|PR.DS-5,ISO/IEC-27001|A.10.1.1,ISO/IEC-27001|A.13.2.3,ITSG-33|SC-8,ITSG-33|SC-8(1),ITSG-33|SC-8a.,NESA|T4.3.1,NESA|T4.3.2,NESA|T4.5.1,NESA|T4.5.2,NESA|T7.3.3,NESA|T7.4.1,NIAv2|IE8,NIAv2|IE9,NIAv2|IE12,NIAv2|NS5d,NIAv2|NS6b,NIAv2|NS29,NIAv2|SS24,QCSC-v1|5.2.2,QCSC-v1|6.2,Rule-ID|SV-220915r569187_rule,STIG-ID|WN10-SO-000040,SWIFT-CSCv1|2.1,TBA-FIISB|29.1,Vuln-ID|V-220915</cm:compliance-reference>

@ejaronne ejaronne added the bug Something isn't working label Jun 3, 2021
@aaronlippold
Copy link
Member

There were also a couple fixes to the standard stig json as well correct that we identified. May as well just keep it in a clean PR

@aaronlippold
Copy link
Member

Also, see email on reply from the DISA Emass folks confirming our discovery on the required data vs the meta-data.

@aaronlippold
Copy link
Member

from the email we recieved: "Additionally, we did confirm that asset matching criteria is checking against Host Name, MAC Address, and IP Address." so by default we should encourge users to provide this info when we create a ckl.

@aaronlippold
Copy link
Member

I think the nessus scan may have some of this meta-data by default

@rx294
Copy link
Contributor

rx294 commented Jun 4, 2021

@aaronlippold @ejaronne

I have a fix for populating
rid (parsed from Nessus' Rule-ID)
CCI (array from Nessus' CCI)
Stig_id (from Neuss' STIG-ID)

However as you know these only exists for the STIG based check entries in the Nessus file... not the plugin based checks

A .nessus could have both plugin and stig based checks...

When we developed the mapper we chose to map both kinds to the hdf file...

would the ingester fail if some controls dont have CCIs,Stig_id,rid?

@aaronlippold
Copy link
Member

Well I guess we would have to say somthing like x=vlaue unless x.nil?

rx294 added a commit that referenced this issue Jun 4, 2021
Signed-off-by: Rony Xavier <[email protected]>
Bialogs pushed a commit that referenced this issue Jun 8, 2021
* Fixes #101
* Adds ruleid, CCI, and stigid to Nessus mapper
* Nessus-related sample updates with new fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants