Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#120 add tooltips to matrices #144

Merged
merged 8 commits into from
May 1, 2020
Merged

Feature/#120 add tooltips to matrices #144

merged 8 commits into from
May 1, 2020

Conversation

JeffJLi
Copy link
Contributor

@JeffJLi JeffJLi commented Apr 29, 2020

Description of what has changed

Added tooltips to all matrices to show technique ID or subtechnique ID when hovering over cells.

Issues addressed by pull request

Closes #120

@JeffJLi JeffJLi added enhancement New feature or request ui The user interface can be improved timescale/imminent Ready to be assigned to developers priority/low Low priority issue labels Apr 29, 2020
@JeffJLi JeffJLi added this to the Version 2.1 milestone Apr 29, 2020
@JeffJLi JeffJLi requested a review from isaisabel April 29, 2020 16:32
isaisabel
isaisabel suggested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@isaisabel isaisabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I realize it wasn't in the original issue, but could you also add tactic ID tooltips to the tactic headers? Just on the tactic name hyperlink. Don't forget to mention that addition in the changelog as well. Thanks!

@JeffJLi
Copy link
Contributor Author

JeffJLi commented Apr 30, 2020

Sure thing! Tooltips for tactic IDs have been added.

@isaisabel isaisabel merged commit e6e77d1 into feature/subtechniques-2.1 May 1, 2020
@jondricek jondricek deleted the feature/#120-add-tooltips-to-matrices branch April 7, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaisabel isaisabel isaisabel approved these changes

Assignees

@isaisabel isaisabel

Labels
enhancement New feature or request priority/low Low priority issue timescale/imminent Ready to be assigned to developers ui The user interface can be improved
Projects
None yet
Milestone
Version 2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffJLi @isaisabel