Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long comments #23

Closed
c2defense opened this issue Mar 19, 2018 · 2 comments
Closed

Long comments #23

c2defense opened this issue Mar 19, 2018 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@c2defense
Copy link

Putting a long comment on a technique at the bottom will cut off so you cannot see the rest of the comment. When you scroll it then flashes. This occurs in the latest Chrome.
untitled

@jburns12
Copy link
Contributor

Thanks for pointing this out, @phlogis . We'll take a look at this and keep this issue updated based on our progress.

@jburns12 jburns12 added the bug Something isn't working label Mar 19, 2018
@isaisabel
Copy link
Contributor

A fix for tooltip length was implemented in the branch bugs/long-tooltips and merged into develop. Two changes to the behavior of tooltips were implemented to mitigate the issue.

  1. The comment section of the tooltip now has a height limit of 300px. This is long enough to show a lot of information while protecting from display issues caused by extremely long comments. The presence of overflowed text is denoted by ellipses (...). Here's a screenshot of how the comment box now looks with a long comment:

    screen shot 2018-03-21 at 7 46 42 am

    Longer comments can still be seen by opening the comment edit field in the technique controls menu.

  2. The tooltip now flips to anchor above the mouse cursor when near the bottom of the page so that it doesn't overflow off the bottom of the page and cause the scrolling behavior you experienced.

@isaisabel isaisabel added this to the Version 2.0 milestone May 10, 2018
gitbook-com bot pushed a commit to FuNianTongXue/attack-navigator that referenced this issue Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants