Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back in keycloak user attributes #4372

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

rhysyngsun
Copy link
Contributor

@rhysyngsun rhysyngsun commented Jan 3, 2025

What are the relevant tickets?

Fixes https://github.com/mitodl/hq/issues/6385

What's this PR do?

This fixes a regression I created when I removed these attributes in a previous PR that are declared as optional in the API and we were passing what I would've thought were defaults but apparently without these Keycloak ignores emailVerified and groups. No idea why.

How should this be manually tested?

Run the migration command and pass --keycloak-group-path. The imported user(s) should be marked as email verified and be part of the group.

@rhysyngsun rhysyngsun requested a review from a team as a code owner January 3, 2025 17:51
@rhysyngsun rhysyngsun requested a review from cp-at-mit January 3, 2025 17:52
@rhysyngsun rhysyngsun merged commit 6d9e708 into master Jan 3, 2025
6 checks passed
@rhysyngsun rhysyngsun deleted the nl/fix-import-bugs branch January 3, 2025 18:47
@odlbot odlbot mentioned this pull request Jan 3, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants