upgrade eslint config, fix errors #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3125 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 246 246
Lines 10741 10741
Branches 1233 1233
=======================================
Hits 9509 9509
Misses 1056 1056
Partials 176 176 Continue to review full report at Codecov.
|
noisecapella
approved these changes
Aug 26, 2020
| @@ -35,6 +35,9 @@ export function useLearningResourcePermalink() { | |||
| }) | |||
| ) | |||
| } | |||
| // dependencies intentionall blank here | |||
this bumps up to the latest version of our shared eslint configuration, which adds an eslint package for linting react hooks. it found a few issues in our code, so I fixed those to get the linter passing. pr #3125
alicewriteswrongs
force-pushed
the
ap/upgrade-eslint
branch
from
8d8f83b to
09fdfd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
none
What's this PR do?
this just updates to the latest version of our eslint configuration, which adds the react-hooks preset. this allows the linter to find a lot of issues where the logic of hooks is being violated - it found a bunch of callbacks which did not have their dependencies properly specified, for instance, which could lead to bugs related to stale data inside the closure of the callback.
How should this be manually tested?
there aren't really any code changes - the only things are renaming some things so that the linter knows they are hooks and turning off rules in a few, specific places. so I think just read through it and make sure things look good, and possibly do a quick smoke test of the app to make sure I didn't break anything.