Add SoftDeleteModel, ActiveUndeleteManager; tests for same #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkachel
force-pushed
the
jkachel/move-soft-undelete-models-to-common
branch
from
d241105 to
458bd9e
Compare
mbertrand
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Looks good at first glance, but in ocw-studio a 3rd-party library was used to add this functionality (django-safedelete). What do you think of using that instead, if it covers all our use cases?
I'm ok with that - the one that I've got here (mostly lifted out of mitxonline) is pretty simple and django-safedelete adds a bunch of stuff we'd probably want anyway (like resurrecting deleted records). So, will close this in favor of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Came up in mitodl/unified-ecommerce#31
Description (What does it do?)
Adds a SoftDeleteModel to the common library, so we can have soft deletions in a common spot. Adds a manager (ActiveUndeleteManager) so models that use the SoftDeleteModel can also optionally default to hiding items that have been deleted.
How can this be tested?
Automated tests should pass. Your model can inherit from SoftDeleteModel, and that should add an
is_activeflag to the model and override thedeletefunction to set the flag to False. Your model can optionally also use theActiveUndeleteManagerso that items that are deleted (is_active == False) are excluded from the queryset by default.