Update download page text when no resources found #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Netlify Deployments: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-www-pr-1475--ocw-next.netlify.app/ |
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-www-pr-1475--ocw-next.netlify.app/search/ |
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-course-v2-pr-1475--ocw-next.netlify.app/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
pdpinch
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
TBH, I find this UX frustrating. I click download in the sidebar and then I have to click download again. The "download page" serves no value.
But, since this is already done and it is an incremental improvement, I guess we should go ahead an merge it. But to do things right, we should rethink this UX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/6189 and closes https://github.com/mitodl/hq/issues/6190.
Description (What does it do?)
This PR makes two changes to the Course Download page when no resources are found for a course:
No Resources Found.message is not displayed.Download coursebutton is updated to the following:This package contains the same content as the online version of the course. Once downloaded, to open the homepage, click on the index.html file. For more help using these materials, read our FAQs.
How can this be tested?
Run
yarn start course <course name>for a course with resources, such as21w.758-spring-2013and then repeat for a course without resources, such as10.01-spring-2020. Confirm that the Download Course page atlocalhost:3000/downloadhas been updated for courses with no resources.