Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation bot styling and text updates #2058

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

jonkafton
Copy link
Contributor

What are the relevant tickets?

Item 2. of https://github.com/mitodl/hq/issues/6747

Description (What does it do?)

  • Updates title to "What do you want to learn from MIT?"
  • Removes strap lines "Need assistance getting started?" and "Let me know how I can help.".
  • Adds a drawer close button to the entry screen; reuses for the chat screen (replacing chat built-in).
  • Removes the "I am curious about AI applications for business..." starter prompt.
  • Also makes some updates to the mobile layout so that it holds in advance of designs.

Screenshots (if appropriate):

image image

How can this be tested?

@jonkafton jonkafton added the Needs Review An open Pull Request that is ready for review label Feb 18, 2025
},
}))

const CloseButton = styled(ActionButton)(({ theme }) => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Figma has a component Close-Modal that is used both here and in the resource drawer.

Ideally, I think this should be a button variant coordinated with Steve and Bilal. But in the meantime, might be worth sticking this in /main/src/components/CloseButton and using in both places 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - it now appears here, in the resource drawer and in the recommendation bot drawer (which turns off this one to reuse between screens).

Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Unrelated to the changes in this PR, I am noticing that the hero area "AskTim" button causes some layout shift. If we're going to enable that on prod soon, might be worth reserving some space for it on the server-rendered page.

@jonkafton jonkafton merged commit 8126fef into main Feb 19, 2025
11 checks passed
@jonkafton jonkafton deleted the 6747-chat-updates branch February 19, 2025 14:56
@jonkafton jonkafton removed the Needs Review An open Pull Request that is ready for review label Feb 19, 2025
@odlbot odlbot mentioned this pull request Feb 19, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants