Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design update for the homepage AskTIM action #2047

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

jonkafton
Copy link
Contributor

What are the relevant tickets?

N/A

Description (What does it do?)

Design update to the homepage AskTIM button.

Screenshots (if appropriate):

image

How can this be tested?

Additional Context

A small design adjustment that we'd like to release today, following from #2019.

@gumaerc gumaerc self-assigned this Feb 13, 2025
Copy link
Contributor

@gumaerc gumaerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -2985,7 +2985,7 @@ __metadata:
languageName: node
linkType: hard

"@mui/utils@npm:^6.1.6":
"@mui/utils@npm:^6.1.6, @mui/utils@npm:^6.4.3":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonkafton I still think this is good to merge, as the Yarn install still works fine, but why was this changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a yarn install locally and it produced that diff - may just be have been dependency release within range.

@jonkafton jonkafton merged commit 8b57ae8 into main Feb 13, 2025
11 checks passed
@jonkafton jonkafton deleted the jk/homepage-recommendation-bot-design branch February 13, 2025 18:55
This was referenced Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants