Condensed list card components for user lists #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbertrand
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Condensed list card components. Apply to ItemsListing page * Style lint * Update test and remove duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4790
Description (What does it do?)
Screenshots (if appropriate):
How can this be tested?
While logged in, navigate to the dashboard "My lists" screen at
/dashboard/#my-listsand select a list. You should have a "My Favorites" list, or can create a new list if necessary.If there are no items in the list, from the homepage or search page, use the card action buttons to add items to you list.
Check the list items render according to designs at desktop and mobile screen widths.
Check variations in Storybook at http://localhost:6006/?path=/story/smoot-design-cards-learningresourcelistcardcondensed--free-course
Additional Context
This adds
Card/ListCardCondensedbase slots template and aLearningResourceCard/LearningResourceListCardCondensedto the ol-components library. These import heavily from their siblingCard/ListCardCondensedandLearningResourceCard/LearningResourceListCard, overriding styles only where they deviate. Relative to the existing resource list cards:Drag and sorting is to be done in a separate task.