Don't send invalid IP addresses in info messages #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes nodes get connected to themselves, or are unable to resolve IP addresses. In that case and IP address such as 127.0.0.1 or 0.0.0.0 might be sent, which will cause the remote peer to disconnect. Add a check for such IP addresses before adding them to the peers list to send with an info message. Also improved the log message for disconnecting a peer behaving in this way to display the offending malformed IP address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes nodes get connected to themselves, or are unable to resolve IP addresses. In that case an IP address such as 127.0.0.1 or 0.0.0.0 might be sent, which will cause the remote peer to disconnect. Add a check for such IP addresses before adding them to the peers list to send with an info message. Also improved the log message for disconnecting a peer behaving in this way to display the offending malformed IP address.