Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix clearing search params #172

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

soniaklimas
Copy link
Contributor

I want to merge this change because it fixes clearing search params related to navigation. Before, if there were any search params related to navigation (e.g. category) and some related to filters while clearing all of them were cleared, even those not related to filters.

Pull Request Checklist

  • Test the changes locally to ensure they work as expected.
  • Document the testing process and results in the pull request description. (Screen recording, screenshot etc)
  • Include new tests for any new functionality or significant changes.
  • Ensure that tests cover edge cases and potential failure points.
  • Document the impact of the changes on the system, including potential risks and benefits.
  • Provide a rollback plan in case the changes introduce critical issues.
  • Update documentation to reflect any changes in functionality.

@soniaklimas soniaklimas self-assigned this Feb 7, 2025
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nimara-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 11:05am
nimara-ecommerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 11:05am

@soniaklimas soniaklimas merged commit 17b0388 into develop Feb 7, 2025
4 checks passed
@soniaklimas soniaklimas deleted the MS-851-fix-clearing-search-filters branch February 7, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants