Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute queries over GET #1160

Merged
merged 11 commits into from
Feb 19, 2024
Merged

Execute queries over GET #1160

merged 11 commits into from
Feb 19, 2024

Conversation

rafalp
Copy link
Collaborator

@rafalp rafalp commented Feb 15, 2024

Adds support for executing GraphQL queries sent over GET, as per spec.

Fixes #123

TODO

  • ASGI
  • WSGI
  • Tests
  • Changelog

@rafalp rafalp added enhancement New feature or request roadmap Feature that we want to have included labels Feb 15, 2024
@rafalp rafalp added this to the Next release milestone Feb 15, 2024
@rafalp rafalp self-assigned this Feb 15, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1698ed5) 97.88% compared to head (2cd2d01) 97.87%.
Report is 5 commits behind head on main.

Files Patch % Lines
ariadne/wsgi.py 90.90% 3 Missing ⚠️
ariadne/graphql.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
- Coverage   97.88%   97.87%   -0.02%     
==========================================
  Files         109      109              
  Lines        7905     8052     +147     
==========================================
+ Hits         7738     7881     +143     
- Misses        167      171       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafalp rafalp marked this pull request as ready for review February 19, 2024 17:42
@rafalp rafalp merged commit f4925c6 into main Feb 19, 2024
21 of 22 checks passed
@rafalp rafalp deleted the fix-123-query-over-get branch February 19, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap Feature that we want to have included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support QUERY execution over the GET
1 participant