-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header environment placeholder not compatible with oauth2 #231
Comments
As a workaround you can do something like
|
proposed naive version:
|
@bombsimon solution is the way to do it. We could add the note in the docs that we are not doing any complex parsing on setting values. |
@bombsimon This utility is used only for headers attached to remote schema introspection query ( |
Ok good for me, I will close the issue |
This allows an environment variable in any position for headers as long as it is in format `$VAR` or `${VAR}` allowing alphanumeric characters and underscore `_`. This is now also applied to `remove_schema_url` in addition to headers. Fixes mirumee#328 Relates to mirumee#231
This allows an environment variable in any position for headers as long as it is in format `$VAR` or `${VAR}` allowing alphanumeric characters and underscore `_`. This is now also applied to `remove_schema_url` in addition to headers. Fixes mirumee#328 Relates to mirumee#231
This allows an environment variable in any position for headers as long as it is in format `$VAR` or `${VAR}` allowing alphanumeric characters and underscore `_`. This is now also applied to `remote_schema_url` in addition to headers. Fixes mirumee#328 Relates to mirumee#231
To whom it may concern,
I think there is an issue with the get_header_value method:
ariadne-codegen/ariadne_codegen/settings.py
Line 246 in 8bc4388
In particular, the value.startswith won't work in case you have the following type of config for oauth2:
remote_schema_headers = {"Authorization" = "Bearer $AUTH_TOKEN"} # extra headers that are passed along with introspection query
The text was updated successfully, but these errors were encountered: