Merge cockroachdb#110775

110775: sql: remove accidental copy of inFlightTraceCollector r=yuzefovich a=michae2 The `finish` method of `inFlightTraceCollector` had a value receiver. I think we meant for this to be a pointer receiver, so that we didn't operate on a copy of the trace collector. Fixes: cockroachdb#110186 Release note: None Co-authored-by: Michael Erickson <[email protected]>
miretskiy · Sep 18, 2023 · d414347 · d414347
2 parents 8fc109c + 7b9a1c9
commit d414347
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/sql/instrumentation.go b/pkg/sql/instrumentation.go
@@ -311,7 +311,7 @@ func pollInFlightTrace(
 	return trace, err
 }
 
-func (c inFlightTraceCollector) finish() {
+func (c *inFlightTraceCollector) finish() {
 	if c.cancel == nil {
 		// The in-flight trace collector goroutine wasn't started.
 		return