Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump embroider libs to v1 #2328

Closed
wants to merge 1 commit into from

Conversation

jrjohnson
Copy link
Contributor

Making the same embroider changes as #2327 to the v2 branch to help resolve embroider-build/embroider#1077 hoping this won't require bumping ember-auto-import as well now that there is a compatible 1.x version release there.

@SergeAstapov
Copy link
Collaborator

@jrjohnson so the problem is that ember-cli-mirage@2 has support for Node.js 10 and @embroider/macros needs 12+ as of 0.42.0

@jrjohnson I think we can release [email protected] so people can start using it if they have fixed all the deprecations (I'd like to get #2314 into beta at minimum)

@cah-briangantzler wdyt?

@jrjohnson
Copy link
Contributor Author

Ah. Makes sense. We'd be happy to jump to an early 3.0 release. Always easy to beta test test libs 😁

@SergeAstapov
Copy link
Collaborator

@jrjohnson I'll try to push #2314 over the line and get early v3 alpha sooner than later

@cah-brian-gantzler
Copy link
Collaborator

3.0 is mostly removing code. I have a PR for another deprecation im working on.

We can get a 3.0 out after we remove all the code, should be a problem if you want to beta it

@jrjohnson
Copy link
Contributor Author

Ok, I'll close this. If there is anything I can do to help with removal I'm jrjohnson on discord.

@jrjohnson jrjohnson closed this Jan 20, 2022
@SergeAstapov
Copy link
Collaborator

@jrjohnson just published v3.0.0-alpha.1 🚀. Please give it a try and report any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants