Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations in Fmt 0.8.10 #36

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fix deprecations in Fmt 0.8.10 #36

merged 1 commit into from
Nov 17, 2021

Conversation

MisterDA
Copy link
Contributor

No description provided.

talex5
talex5 reviewed Nov 17, 2021
View reviewed changes
Copy link
Contributor

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the opam file needs updating with the new minimum version.

@MisterDA
Copy link
Contributor Author

You're right, fmt {>= "0.8.7"} should be ok.

@talex5 talex5 merged commit bc5b0cb into mirage:master Nov 17, 2021
@talex5
Copy link
Contributor

talex5 commented Nov 17, 2021

Thanks!

@MisterDA MisterDA deleted the fmt-deprecation branch November 17, 2021 11:36
talex5 added a commit to talex5/opam-repository that referenced this pull request Jun 16, 2022
@talex5
[new release] prometheus and prometheus-app (1.2)
9ccb62e 
CHANGES:

- Add lwt collectors and pre-collectors (@killian-delarue, mirage/prometheus#43).
  Note that this is a temporary feature while we wait for OCaml 5 to be released,
  when this can be replaced by the use of effects.

- Fix deprecations in Fmt 0.8.10 (@MisterDA, mirage/prometheus#36).

- General build updates, upstream deprecations, etc (@talex5, mirage/prometheus#33 mirage/prometheus#34 mirage/prometheus#35 mirage/prometheus#40 mirage/prometheus#42).
@talex5 talex5 mentioned this pull request Jun 16, 2022
Merged
talex5 added a commit to talex5/opam-repository that referenced this pull request Jun 16, 2022
@talex5
[new release] prometheus and prometheus-app (1.2)
c753eac 
CHANGES:

- Add lwt collectors and pre-collectors (@killian-delarue, mirage/prometheus#43).
  Note that this is a temporary feature while we wait for OCaml 5 to be released,
  when this can be replaced by the use of effects.

- Fix deprecations in Fmt 0.8.10 (@MisterDA, mirage/prometheus#36).

- General build updates, upstream deprecations, etc (@talex5, mirage/prometheus#33 mirage/prometheus#34 mirage/prometheus#35 mirage/prometheus#40 mirage/prometheus#42).
talex5 added a commit to talex5/opam-repository that referenced this pull request Jun 16, 2022
@talex5
[new release] prometheus and prometheus-app (1.2)
3159503 
CHANGES:

- Add lwt collectors and pre-collectors (@killian-delarue, mirage/prometheus#43).
  Note that this is a temporary feature while we wait for OCaml 5 to be released,
  when this can be replaced by the use of effects.

- Fix deprecations in Fmt 0.8.10 (@MisterDA, mirage/prometheus#36).

- General build updates, upstream deprecations, etc (@talex5, mirage/prometheus#33 mirage/prometheus#34 mirage/prometheus#35 mirage/prometheus#40 mirage/prometheus#42).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talex5 talex5 talex5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MisterDA @talex5