Add unregister_and_flush call #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Magnus Skjegstad <[email protected]>
Adds `unregister_and_flush` to allow a node to unregister from the backend, but block until all that node's listener callbacks have returned. This is particularly useful when using async listeners, as they may be running after the listener has been removed from the backend. Note that this may also block forever if the listener callbacks are not designed to return (such as in `mirage-tcpip`). Signed-off-by: Magnus Skjegstad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
unregister_and_flushto allow a node to unregister from thebackend and block until all that node's listener callbacks have returned. This is
particularly useful when using async listeners, as they may still be processing
packets after the listener has been removed from the backend.
Note that this may also block forever if the listener callbacks are not
designed to return (such as in
mirage-tcpip).Each call to the listener callback now increments a counter per mac/node, which is
decremented when the call returns and a condition variable is signalled. The new
unregister_and_flushfunction will wait for the counter to reach 0 before unregisteringthe node id.