Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unikernel for ipaddr >= 2.9.0 compat #389

Merged
merged 2 commits into from
Jan 14, 2019
Merged

fix unikernel for ipaddr >= 2.9.0 compat #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e61235b
fix unikernel for ipaddr >= 2.9.0 compat
hannesm Jan 14, 2019
42d17fb
lower bound on ipaddr used
hannesm Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/unikernel/config.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
open Mirage

let main = foreign "Services.Main" (stackv4 @-> job)
let main =
let packages = [ package ~min:"2.9.0" "ipaddr" ] in
foreign ~packages "Services.Main" (stackv4 @-> job)

let stack = generic_stackv4 default_network

Expand Down
2 changes: 1 addition & 1 deletion examples/unikernel/services.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module Main (S: Mirage_types_lwt.STACKV4) = struct
let ip, port = S.TCPV4.dst flow in
Logs.warn
(fun m -> m "closing connection from %a:%d due to error %a while %s"
Ipaddr.V4.pp_hum ip port pp e message);
Ipaddr.V4.pp ip port pp e message);
S.TCPV4.close flow

let rec chargen flow how_many start_at =
Expand Down