don't suppress deprecation warnings (3)

[hannesm]

as noticed in mirage/mirage-net-xen#79 (comment) - I'm actually in favour of not suppressing warnings to remind ourselves that we need to work on this... Lwt_sequence getting deprecated as tracked in mirage/mirage#889

[avsm]

The issue is that this breaks the default warnings-as-errors mode of dune (which is otherwise reasonable during development). The issue with the Lwt_sequence deprecation is that there's no clear solution to it yet, so the function is marked as deprecated but can't actually be immediately fixed (without pulling out Lwt_sequence into a separate package). So I'd prefer to keep track of these sorts of warnings in issue (as done in mirage/mirage#889) and suppress the deprecation warning until we're ready to fix it.

[emillon]

An in-between solution is to explicitly mark the problematic modules with:

[@@@ocaml.warning "-3"]
module Lwt_sequence = Lwt_sequence (* see issue #xxx *)
[@@@ocaml.warning "+3"]

BTW do you know if there's a plan to extract the existing Lwt_sequence to opam? A verified version would be nice but it does not seem necessary to wait for it.

[avsm]

BTW do you know if there's a plan to extract the existing Lwt_sequence to opam? A verified version would be nice but it does not seem necessary to wait for it.

I did a quick extraction to https://github.com/mirage/lwt-dllist -- as soon as there is agreement on #349 i can cut a release and we can use that instead of the builtin version.

[avsm]

fixed by #388 instead