Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Dhcp functor is applied inside Tcpip_stack_direct.Make #168

Closed
Drup opened this issue Aug 24, 2015 · 6 comments
Closed

The Dhcp functor is applied inside Tcpip_stack_direct.Make #168

Drup opened this issue Aug 24, 2015 · 6 comments

Comments

@Drup
Copy link
Member

Drup commented Aug 24, 2015

See

module Dhcp = Dhcp_clientv4.Make(Console)(Time)(Random)(Udpv4)

If we follow the logic, this should be an argument.

@Drup
Copy link
Member Author

Drup commented Aug 24, 2015

Actually, I went and look, and there is no .mli for the dhcp part, and it seems in general that this part didn't got a lot of love.

@avsm
Copy link
Member

avsm commented Aug 25, 2015

In general it would be good to make the Dhcp stack a client of the Tcpip stack. The plan is to use https://github.com/haesbaert/hdhcp as the code base for this rather than the rather adhoc one thats currently in the mirage-tcpip codebase. (/cc @haesbaert)

@mor1
Copy link
Member

mor1 commented Aug 25, 2015

There is also the code that Alistair (UROP student) has been working on. At
some point I believe he was in touch with Christiano but not sure where
that led. He seemed to have made some progress on producing a dhcpd at
least, and was (I believe) due to be talking with @yomimono about applying
some Irmin goodness to it. (I don't think he'd yet extracted it from
mirage-tcpip though.)

On 25 August 2015 at 13:30, Anil Madhavapeddy [email protected]
wrote:

In general it would be good to make the Dhcp stack a client of the Tcpip
stack. The plan is to use https://github.com/haesbaert/hdhcp as the code
base for this rather than the rather adhoc one thats currently in the
mirage-tcpip codebase. (/cc @haesbaert https://github.com/haesbaert)


Reply to this email directly or view it on GitHub
#168 (comment)
.

Richard Mortier
[email protected]

@haesbaert
Copy link
Member

Not really, no one contacted me, wasn't aware there was another
implementation going on.

I have released the library needed for hdhcp on opam this weekend and hdhcp
seems to be functional, I've started to work on converting it to mirage.

On Tuesday, August 25, 2015, Richard Mortier [email protected]
wrote:

There is also the code that Alistair (UROP student) has been working on. At
some point I believe he was in touch with Christiano but not sure where
that led. He seemed to have made some progress on producing a dhcpd at
least, and was (I believe) due to be talking with @yomimono about applying
some Irmin goodness to it. (I don't think he'd yet extracted it from
mirage-tcpip though.)

On 25 August 2015 at 13:30, Anil Madhavapeddy <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

In general it would be good to make the Dhcp stack a client of the Tcpip
stack. The plan is to use https://github.com/haesbaert/hdhcp as the code
base for this rather than the rather adhoc one thats currently in the
mirage-tcpip codebase. (/cc @haesbaert https://github.com/haesbaert)


Reply to this email directly or view it on GitHub
<
https://github.com/mirage/mirage-tcpip/issues/168#issuecomment-134570460>
.

Richard Mortier
[email protected] javascript:_e(%7B%7D,'cvml','[email protected]');


Reply to this email directly or view it on GitHub
#168 (comment)
.

@mor1
Copy link
Member

mor1 commented Aug 26, 2015

@haesbaert Drat, sorry about that. My bad :( /cc @alistairfisher
Alistair has a Mirage DHCP server working, but based off the DHCP code that was here in mirage-tcpip so less complete than yours. After discussion with @yomimono, he's also started to work on applying Irmin to hold the state of the server.

How far have you got with the Mirage server version so far -- perhaps worth the two of you joining forces?

@haesbaert
Copy link
Member

I kinda just need to adapt the IO code functorizing the server, there isn't much code to write, the thing is I'm only now getting familiar with mirage, most of the work is just shuffling things here and there to fit. I hope to have it ready by next week or this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants