New layout about freestanding & xen artifacts #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
Oct 27, 2020
hannesm
reviewed
Oct 27, 2020
hannesm
reviewed
Oct 27, 2020
hannesm
reviewed
Oct 27, 2020
hannesm
reviewed
Oct 27, 2020
hannesm
reviewed
Oct 27, 2020
|
looks pretty good (though I'm not entirely sure about the C macro changes). I added some minor comments - in the test mirage unikernel you should not commit the generated code. |
hannesm
reviewed
Oct 28, 2020
hannesm
reviewed
Oct 28, 2020
hannesm
reviewed
Oct 28, 2020
hannesm
reviewed
Oct 28, 2020
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Nov 3, 2020
CHANGES: - **breaking changes** Upgrade the library with MirageOS 3.9 (new layout of artifacts) Add tests about compilation of unikernels (execution and link) (mirage/digestif#105, @dinosaure, @hannesm) - Fix `esy` installation (mirage/digestif#104, @dinosaure) - **breaking changes** Better GADT (mirage/digestif#103, @dinosaure) As far as I can tell, nobody really use this part of `digestif`. The idea is to provide a GADT which contains the type of the hash. From third-part libraries point-of-view, it's better to _pattern-match_ with such information instead to use a polymorphic variant (as before). - **breaking changes** key used for HMAC is a constant `string` (mirage/digestif#101, @dinosaure, @hannesm) The key should not follow the same type as the digest value (`string`, `bytes`, `bigstring`). This update restricts the user to user only constant key (as a `string`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New layout which provides only
libdigestif_freestanding_stubs.anow to follow upgrade of C stubs formirage.3.9.0. I'm not sure about this update, @hannesm can you look into this? I mostly followed what it was done into mirage/mirage-crypto#86.I deleted the way to unlock the GC when we try to digest a bigarray for the
freestandingwherecaml/threads.hdoes not exists.