Tempo loader #210
Tempo loader #210
Conversation
| Path to the annotation file | ||
| delimiter : str | ||
| Separator regular expression. | ||
| By default, lines will be split by any amount of whitespace. |
There was a problem hiding this comment.
Nitpick: "lines" is a bit of a misnomer here, since we require that there only be a single line.
There was a problem hiding this comment.
This should be tokens/columns, right?
There was a problem hiding this comment.
Depends on your perspective I guess. Is it the line that's getting split into tokens/columns, or are the tokens/columns being solit out of the line or something?
There was a problem hiding this comment.
Er, I stole that comment from the key loader... sounds like your fault 😁
But in general, it's the line(s) being split into columns. I think the existing description is correct. (The fact that there should only be one line is orthogonal to how lines are processed.)
|
Thank you! Made one tiny docstring nitpick, otherwise LGTM. Feel free to fix and merge at will. |
|
Merged, thanks again. |
implements #183