Restore behavior to avoid inferring dependencies

miqm · Sep 20, 2024 · cc02f3d · cc02f3d
1 parent fbe41a7
commit cc02f3d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/Bicep.Core.IntegrationTests/Scenarios/NameofFunctionTests.cs b/src/Bicep.Core.IntegrationTests/Scenarios/NameofFunctionTests.cs
@@ -241,7 +241,7 @@ public void NameofFunction_OnResourceProperty_ReturnsResourcePropertyName(string
         }
 
         [TestMethod]
-        public void UsingNameofFunction_ShouldGenerateDependsOnEntries()
+        public void UsingNameofFunction_ShouldNotGenerateDependsOnEntries()
         {
             var result = CompilationHelper.Compile("""
 resource myStorage 'Microsoft.Storage/storageAccounts@2019-06-01' = {
@@ -257,7 +257,7 @@ public void UsingNameofFunction_ShouldGenerateDependsOnEntries()
             {
                 result.Should().NotHaveAnyCompilationBlockingDiagnostics();
                 result.Template.Should().HaveValueAtPath("$.resources[?(@.type == 'Microsoft.Sql/servers')].name", "myStorage", "Nameof function should emit static string during compilation");
-                result.Template.Should().HaveValueAtPath("$.resources[?(@.type == 'Microsoft.Sql/servers')].dependsOn[0]", "[resourceId('Microsoft.Storage/storageAccounts', 'storage123')]");
+                result.Template.Should().NotHaveValueAtPath("$.resources[?(@.type == 'Microsoft.Sql/servers')].dependsOn", "Depends on should not be generated for nameof function usage");
             }
         }
 

diff --git a/src/Bicep.Core/Emit/ResourceDependencyVisitor.cs b/src/Bicep.Core/Emit/ResourceDependencyVisitor.cs
@@ -7,6 +7,7 @@
 using Bicep.Core.Semantics;
 using Bicep.Core.Semantics.Metadata;
 using Bicep.Core.Syntax;
+using Bicep.Core.TypeSystem;
 
 namespace Bicep.Core.Emit
 {
@@ -282,6 +283,15 @@ public override void VisitObjectPropertySyntax(ObjectPropertySyntax propertySynt
             base.VisitObjectPropertySyntax(propertySyntax);
         }
 
+        public override void VisitFunctionCallSyntax(FunctionCallSyntax syntax)
+        {
+            var functionSymbol = model.GetSymbolInfo(syntax) as FunctionSymbol;
+            if (ShouldVisitFunctionArguments(functionSymbol))
+            {
+                base.VisitFunctionCallSyntax(syntax);
+            }
+        }
+
         private bool IsTopLevelPropertyOfCurrentDeclaration(ObjectPropertySyntax propertySyntax)
         {
             SyntaxBase? declaringSyntax = this.currentDeclaration switch
@@ -294,5 +304,8 @@ private bool IsTopLevelPropertyOfCurrentDeclaration(ObjectPropertySyntax propert
 
             return currentDeclarationProperties?.Contains(propertySyntax) ?? false;
         }
+
+        private static bool ShouldVisitFunctionArguments(FunctionSymbol? functionSymbol)
+            => functionSymbol is null || !functionSymbol.FunctionFlags.HasFlag(FunctionFlags.IsArgumentValueIndependent);
     }
 }