Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from google:master #255

Open
wants to merge 1,157 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1157 commits
Select commit Hold shift + click to select a range
636e580
Stop hashing in presized ImmutableSortedSet.Builders in java7 variant…
lowasser Aug 6, 2024
6bd3a14
Make ImmutableSet.Builder.addAll(Set) smarter about sizing the intern…
java-team-github-bot Aug 6, 2024
7c4ca41
Validate that ImmutableSortedSet.Builder is O(n log n).
lowasser Aug 9, 2024
36dfb16
Simplify the implementation of a test `Predicate`.
cpovirk Aug 12, 2024
0cb9cc6
Group overloads.
cpovirk Aug 12, 2024
e232035
Fix ImmutableList.Builder to throw a useful exception when its size w…
lowasser Aug 12, 2024
a4a7f6b
Recommend the JDK `compareUnsigned` methods over our equivalents.
cpovirk Aug 12, 2024
a94ff8b
Update nullness annotations after cl/662127972, and prepare for the f…
cpovirk Aug 16, 2024
e1eaeff
Prepare for release 33.3.0.
cpovirk Aug 16, 2024
55911e8
Bump the github-actions group with 2 updates
dependabot[bot] Aug 16, 2024
d619273
Suppress Error Prone findings locally.
cpovirk Aug 19, 2024
7c9455c
Bump github/codeql-action in the github-actions group
dependabot[bot] Aug 19, 2024
7810685
Synchronize on empty arrays instead of `Integer` instances.
cpovirk Aug 19, 2024
388e098
Call `Thread.suspend` and `resume` reflectively (when we even try to …
cpovirk Aug 22, 2024
137798d
Specify `@InlineMe` for `{Doubles,Floats}#compare`
Stephan202 Aug 23, 2024
508cef7
Changed `*.concat()` to throw `IllegalArgumentException` if the input…
Aug 27, 2024
bff7090
Stop testing code with inaccurate nullness annotations under J2KT.
cpovirk Aug 27, 2024
9c84ddb
Remove comments about compiling with JDK 8.
cpovirk Aug 29, 2024
27c5440
Bump github/codeql-action in the github-actions group
dependabot[bot] Aug 30, 2024
bb9fc23
Bump the github-actions group with 2 updates
dependabot[bot] Sep 4, 2024
930cc58
Bump actions/setup-java from 4.2.2 to 4.3.0 in the
dependabot[bot] Sep 9, 2024
7bc08c1
Remove stale comments about `@NonNull` annotations in the JDK.
cpovirk Sep 10, 2024
294f07d
Bump github/codeql-action in the github-actions group
dependabot[bot] Sep 16, 2024
e5b58e2
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code.
cpovirk Sep 17, 2024
6a070d8
Bump github/codeql-action in the github-actions group
dependabot[bot] Sep 23, 2024
a3b5188
Include `j2objc-annotations` in the Gradle runtime classpath.
cpovirk Sep 23, 2024
d9dbb15
Fix one instance of incorrect nullability of type argument in FluentI…
java-team-github-bot Sep 24, 2024
3c7c173
Prepare for release 33.3.1.
cpovirk Sep 24, 2024
7c0bf08
Add `application/cbor` to `MediaType`.
kstich Sep 26, 2024
f358c05
Use JDK 23 for compilation (and a few other plugins), while keeping o…
cpovirk Oct 1, 2024
503ba42
Add `HttpHeaders.ALT_SVC`; see https://datatracker.ietf.org/doc/html/…
kluever Oct 1, 2024
f640a0f
Bump the github-actions group with 3 updates
dependabot[bot] Oct 1, 2024
5da71a7
Fix some misconfigured collections test suites that were passing due …
chaoren Oct 2, 2024
81be061
Fix `@Require` annotations so that features implied by absent feature…
chaoren Oct 5, 2024
a46565d
Provide an optimized copyOf method for TreeRangeMap
java-team-github-bot Oct 6, 2024
ed33d3d
Bump github/codeql-action in the github-actions group
dependabot[bot] Oct 7, 2024
4d7c71e
Add `@RetainedLocalRef` to `volatile` `value` field references to res…
java-team-github-bot Oct 8, 2024
01e6a55
Refactor `getDoneValue(Object obj)` to improve readability of `Cancel…
java-team-github-bot Oct 8, 2024
49776fd
Address https://errorprone.info/bugpattern/Interruption warnings.
cpovirk Oct 8, 2024
99d2ced
Remove @GwtIncompatible from LongMath.checkedSubtract
java-team-github-bot Oct 9, 2024
f5ec2ab
add `ToStringHelper.omitEmptyValues()`. Fixes https://github.com/goog…
kluever Oct 9, 2024
d40589d
Avoid backticks in Javadoc.
cpovirk Oct 10, 2024
b84a41d
n/a
lowasser Oct 11, 2024
ccb3c85
Bump the github-actions group with 3 updates
dependabot[bot] Oct 14, 2024
9be5c72
Bump Maven to 3.9.9 and Wrapper to 3.3.2.
cpovirk Oct 14, 2024
77243d6
Add a note about `Thread.Factory` for Java 21+ users. See https://git…
kluever Oct 14, 2024
0a29129
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.col…
cpovirk Oct 15, 2024
5338f7c
Upgrade to a version of `plexus-io` from after a performance improvem…
cpovirk Oct 16, 2024
503c9eb
Add Fingerprint2011 to ChecksumBenchmark
java-team-github-bot Oct 16, 2024
10d4b1b
Inline a method that mainly serves to confuse the compiler's reachabi…
cpovirk Oct 16, 2024
98d5528
Address https://errorprone.info/bugpattern/UnnecessaryDefaultInEnumSw…
cpovirk Oct 16, 2024
702e4b2
Disable `Java7ApiChecker` for our *tests*, removing most of its suppr…
cpovirk Oct 16, 2024
ca12c33
Address [CatchFail](https://errorprone.info/bugpattern/CatchFail), [S…
cpovirk Oct 17, 2024
8f747d0
Migrate off `Throwables.propagate`, and stop rethrowing exceptions fr…
cpovirk Oct 17, 2024
0e2fa3e
Address https://errorprone.info/bugpattern/ThreadPriorityCheck warnings.
cpovirk Oct 17, 2024
1337405
Use `addSuppressed` in `AbstractExecutionThreadService`, and otherwis…
cpovirk Oct 17, 2024
2212495
Migrate more code to use `UndeclaredThrowableException`.
cpovirk Oct 17, 2024
dc423d2
Address [StaticQualifiedUsingExpression](https://errorprone.info/bugp…
cpovirk Oct 17, 2024
585b93a
Restore the behavior of throwing an `IllegalArgumentException` directly.
cpovirk Oct 17, 2024
7b62a51
Point users to [`Math.clamp`](https://docs.oracle.com/en/java/javase/…
cpovirk Oct 17, 2024
9597b0d
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.col…
cpovirk Oct 17, 2024
8a1c90e
Prepare for usage of `ReflectionFreeAssertThrows` from more packages:
cpovirk Oct 17, 2024
99be0a4
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.col…
cpovirk Oct 17, 2024
6082782
Make `Splitter.splitToStream` available to Android users.
cpovirk Oct 17, 2024
b0461b7
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.cac…
cpovirk Oct 18, 2024
b045bf3
Suppress a suggestion that we use the `Duration` overload.
cpovirk Oct 18, 2024
f5108a3
Use some static imports.
cpovirk Oct 18, 2024
dc12fb2
Address [InitializeInline](https://errorprone.info/bugpattern/Initial…
cpovirk Oct 18, 2024
3a8463a
Use some static imports.
cpovirk Oct 18, 2024
266b30c
Use some static imports.
cpovirk Oct 18, 2024
8bbbefd
Use _more_ static imports.
cpovirk Oct 19, 2024
89ca0ef
Use some static imports.
cpovirk Oct 19, 2024
cdc2254
Make most `util.concurrent` `Duration` overloads available to Android…
cpovirk Oct 19, 2024
fea7a36
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.pri…
cpovirk Oct 19, 2024
6544c1e
Update links from code.google.com to github.com.
cpovirk Oct 21, 2024
f617e81
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.net…
cpovirk Oct 21, 2024
031cefa
Remove a couple more obsolete workarounds for `FilterOutputStream` tr…
cpovirk Oct 21, 2024
9911c83
Internal change.
cpovirk Oct 21, 2024
79c9e7a
Remove a couple more obsolete workarounds for `FilterOutputStream` tr…
java-team-github-bot Oct 21, 2024
67f9149
Extract shared helper methods in `UrlEscapersTest` into `UrlEscaperTe…
cpovirk Oct 21, 2024
3d14f1d
Complete the automatable migration to `assertThrows`.
cpovirk Oct 21, 2024
10c64d9
Internal change.
cpovirk Oct 22, 2024
f9f3fff
Expose more Java 8 APIs to Android users.
cpovirk Oct 23, 2024
9938818
Use `@RetainedLocalRef` to keep J2ObjC from deallocating objects when…
cpovirk Oct 25, 2024
19fef9b
Avoid varargs allocations in `min`/`max` calls.
cpovirk Oct 25, 2024
309365e
Miscellaneous followup from cl/687404334.
cpovirk Oct 25, 2024
984f713
Expose more Java 8 APIs to Android users.
cpovirk Oct 25, 2024
c6c2680
Expose more Java 8 APIs to Android users.
cpovirk Oct 25, 2024
2f04514
Eliminate unnecessary conversion to byte array.
guoci Oct 26, 2024
b650b9f
Expose more Java 8 APIs to Android users.
cpovirk Oct 26, 2024
ea06095
Copy an `Entry` to avoid undefined behavior after the `Map` is modified.
cpovirk Oct 27, 2024
dc30916
Roll forward cl/688155711, which was rolled back in cl/688191691.
cpovirk Oct 28, 2024
26ea2d4
Improve the error message for `assertNull` in test-suite-builder tests.
cpovirk Oct 28, 2024
2a36be1
Bump the github-actions group with 3 updates
dependabot[bot] Oct 29, 2024
167113a
Use **more** static imports.
cpovirk Oct 30, 2024
85d08ec
Use `Iterables.transform` again (except for one method that apparentl…
cpovirk Oct 30, 2024
5a63833
Remove unused import.
cpovirk Oct 30, 2024
664c80b
Fix another accidental use of varargs `min`/`max` calls.
cpovirk Oct 30, 2024
6ace8bc
Expose more Java 8 APIs to Android users.
cpovirk Oct 31, 2024
99d75d1
Add tester classes for Java 8 APIs to the Android flavor.
cpovirk Oct 31, 2024
9b0109c
Expose some `common.io` Java 8 APIs to Android users.
cpovirk Oct 31, 2024
68d28ec
Bump github/codeql-action in the github-actions group
dependabot[bot] Nov 11, 2024
c309175
Avoid iterating thrice in SetView.immutableCopy()
java-team-github-bot Nov 11, 2024
f7bb711
Document that `isInetAddress` and `forString` perform slightly differ…
cpovirk Nov 13, 2024
ed2c12a
Clarify comments about our usage of `@Ignore` and the associated supp…
cpovirk Nov 14, 2024
7a61ca9
Use `hasMessageThat` and `hasCauseThat`.
cpovirk Nov 15, 2024
747dd4b
Fix a tiny Javadoc error on UnsignedInteger.doubleValue.
java-team-github-bot Nov 15, 2024
166bb20
Link to Java 21 Javadoc instead of Java 9.
cpovirk Nov 15, 2024
9166ed0
Bump github/codeql-action in the github-actions group
dependabot[bot] Nov 18, 2024
3853b98
Stop warning that Caffeine requires Java 8.
cpovirk Nov 20, 2024
c799c38
Fix some Javadoc warnings, mostly around the use of the default const…
cpovirk Nov 20, 2024
27bb9c2
Fix typo from cl/698442998.
cpovirk Nov 20, 2024
4d4b29c
Add docs for `TreeRangeMap`, including `@since` tag for the `copyOf` …
cpovirk Nov 20, 2024
45e6be2
Deprecate `Charsets` constants.
kluever Nov 25, 2024
74c75ca
Bump github/codeql-action in the github-actions group
dependabot[bot] Nov 25, 2024
cf508b7
Bump Error Prone to 2.36.0, including setting `--should-stop=ifError=…
cpovirk Nov 26, 2024
335950b
Remove obsolete link to ancient site.
cpovirk Nov 26, 2024
8a24204
Internal change
java-team-github-bot Nov 27, 2024
5d6e2bd
Suppress https://errorprone.info/bugpattern/ThrowIfUncheckedKnownUnch…
cpovirk Dec 4, 2024
6832b54
Remove a test that creates a `SecurityManager`.
eamonnmcmanus Dec 5, 2024
03d3b70
Internal change.
eamonnmcmanus Dec 6, 2024
3bb6101
Improve the calculation of the optimal number of hash functions for a…
Romain-E Dec 8, 2024
3644d61
Remove tests that create a `SecurityManager`.
eamonnmcmanus Dec 9, 2024
54cc5ea
Make `Joiner` sometimes use `String.join`, which was [optimized](http…
cpovirk Dec 10, 2024
983c106
Fix/suppress more warnings.
cpovirk Dec 10, 2024
2aa8fd9
Bump github/codeql-action in the github-actions group
dependabot[bot] Dec 10, 2024
e307cae
Remove tests that rely on a `SecurityManager`.
eamonnmcmanus Dec 11, 2024
62c6187
Recommend `Cleaner` instead of `FinalizableReferenceQueue`.
eamonnmcmanus Dec 12, 2024
a124c1e
Release `testMyServerExampleWithCleaner` publicly.
cpovirk Dec 12, 2024
660e5dc
Prefactoring for future changes that will avoid using `Unsafe`.
cpovirk Dec 13, 2024
2496b4e
Bump github/codeql-action in the github-actions group
dependabot[bot] Dec 16, 2024
617fd28
Prepare for release 33.4.0.
cpovirk Dec 16, 2024
e25ee0c
In `ClosingFuture`, remove a workaround for [JDK-7101822](https://bug…
cpovirk Dec 16, 2024
15617f5
Add some nullness annotations to tests.
cpovirk Dec 19, 2024
24e20e4
Add JSpecify as a build dependency without using it yet.
cpovirk Dec 19, 2024
a0b90e7
Explicitly annotate some null-unmarked classes as `@NullUnmarked`.
cpovirk Dec 19, 2024
d1f9419
Remove workarounds for a bug in Java 5.
cpovirk Dec 19, 2024
831793c
Remove workarounds and update comments related to old JDKs.
cpovirk Dec 19, 2024
7ee7759
Update links to refer to the new bug tracker.
cpovirk Dec 19, 2024
d9ed9b9
Annotate `*GwtSerializationDependencies` classes for nullness.
cpovirk Dec 19, 2024
cc2c5d3
Stop building collection-test-suite-builder code for J2KT.
cpovirk Dec 19, 2024
5fe9d20
Promote `@ElementTypesAreNonnullByDefault` to the package level, repl…
cpovirk Dec 20, 2024
ce43463
Remove class-level `@ElementTypesAreNonnullByDefault` annotations.
cpovirk Dec 21, 2024
8ebb375
Use `@NullMarked` instead of our custom `@ElementTypesAreNonnullByDef…
cpovirk Dec 21, 2024
17634b5
Change `<? extends @Nullable Object>` back to `<?>`.
cpovirk Dec 21, 2024
ae36f57
Turn `@ParametricNullness` into a no-op for Kotlin and IntelliJ, and …
cpovirk Dec 21, 2024
d997ad9
Migrate from `@CheckForNull` to Checker Framework `@Nullable`.
cpovirk Dec 21, 2024
04bf030
Remove dependency on JSR-305.
cpovirk Dec 22, 2024
2cc8c5e
Migrate from Checker Framework annotations to JSpecify annotations.
cpovirk Dec 22, 2024
800b3d4
Remove dependency on Checker Framework annotations.
cpovirk Dec 22, 2024
58fb2eb
Adding test scenarios related to leading and trailing spaces when par…
java-team-github-bot Dec 27, 2024
a3e17c2
Apply inlinings where possible and appropriate, and suppress elsewhere.
cpovirk Dec 27, 2024
4067301
Sort some lists, removing a duplicate.
cpovirk Dec 27, 2024
1462a03
Standardize on `sneakyThrow` for "impossible" checked exceptions.
cpovirk Dec 27, 2024
470f16f
Fixed `MixedArrayDimensions` warnings.
cpovirk Dec 27, 2024
9b05674
Address more `ConstantCaseForConstants` warnings.
cpovirk Dec 28, 2024
215f256
Fix or suppress `IdentifierName` (and sometimes `ConstantNameForConst…
cpovirk Dec 28, 2024
92eb5b4
Fix a race condition in `FinalizableReferenceQueueTest`.
eamonnmcmanus Dec 30, 2024
d10797e
Clarify documentation of `sneakyThrow`.
cpovirk Dec 30, 2024
69d96d0
Regenerate directories of GWT sources from scratch each time.
cpovirk Jan 2, 2025
c146772
Specify versions for plugins.
cpovirk Jan 2, 2025
4559277
Apply or suppress suggestions to use `@InlineMe`.
cpovirk Jan 2, 2025
2c6e3b9
Make it possible to actually use (e.g.) `-Dsurefire.toolchain.version…
cpovirk Jan 2, 2025
80559d2
Expose [JSpecify annotations](https://github.com/jspecify/jspecify/is…
cpovirk Jan 2, 2025
1a300f6
Make `AbstractFuture` use `VarHandle` when available.
cpovirk Jan 3, 2025
c171b9c
Mess around more with Javadoc and Maven toolchains:
cpovirk Jan 3, 2025
7ac7965
Make Javadoc link to JSpecify classes.
cpovirk Jan 3, 2025
c03d604
Use `@linkplain` instead of `<a href="...">`.
cpovirk Jan 3, 2025
993aa76
Fix linking to JDK 21 from the Guava Javadoc.
cpovirk Jan 3, 2025
c9e6926
Minor updates after recent changes for Java 8 APIs.
cpovirk Jan 3, 2025
ff7c071
Use JDK 23 for generating Javadoc, too.
cpovirk Jan 3, 2025
bc1b209
Bump build timestamp to 2025.
cpovirk Jan 4, 2025
c8b8041
Bump the github-actions group with 3 updates
dependabot[bot] Jan 6, 2025
5a0e12f
Update and explicitly mention "Javadoc" on README
vorburger Jan 6, 2025
4b6f871
Fix the CI badge.
chaoren Jan 6, 2025
12bf71e
Address some https://errorprone.info/bugpattern/UnnecessaryJavacSuppr…
cpovirk Jan 7, 2025
400af25
Make `AtomicReferenceFieldUpdater` fields `static` for [better perfor…
cpovirk Jan 7, 2025
d1a3cd5
Under the JRE, use `java.util.concurrent.atomic.LongAdder` unconditio…
cpovirk Jan 8, 2025
0180d09
Restore Sonatype configuration that I'd accidentally removed in cl/71…
cpovirk Jan 9, 2025
aeb9099
Clarify `CharMatcher.precomputed()` javadocs a bit. Also mention "keb…
kluever Jan 9, 2025
77cf121
Changing Void to be annotated with @Nullable and updating any other n…
jparachoniak Jan 10, 2025
b3bb29a
Make `UnsignedBytes.lexicographicalComparator()` use `Arrays.compareU…
cpovirk Jan 10, 2025
80aab00
Remove `Unsafe`-based implementation from `ExecutionListBenchmark`.
cpovirk Jan 10, 2025
ee63055
Make `common.hash` use `VarHandle` [instead of `Unsafe`](https://gith…
cpovirk Jan 14, 2025
71d0692
Make `UnsignedBytesTest` actually check that we are using the correct…
cpovirk Jan 14, 2025
30aee2e
Bump the github-actions group with 2 updates
dependabot[bot] Jan 14, 2025
d6ceb21
Fix automatic toolchain downloads again.
cpovirk Jan 15, 2025
18131c0
Update suppressions for usage of `sun.misc.Unsafe`.
cpovirk Jan 15, 2025
3b077bc
Sort `<plugins>` in `<pluginManagement>` to prevent #7622 from happen…
chaoren Jan 15, 2025
22046a3
Prepare for the removal of `blogspot.*` ccTLD domains from the Public…
cpovirk Jan 17, 2025
a3d5c96
Attempt to fix some recent flakiness in `testAwaitFullGc`.
cpovirk Jan 17, 2025
176cf74
Reformat.
cpovirk Jan 18, 2025
ee3b9c6
Update Public Suffix List data.
cpovirk Jan 22, 2025
172b19a
Fix typo.
cpovirk Jan 22, 2025
bc1d74f
Address some http://errorprone.info/bugpattern/CatchingUnchecked warn…
cpovirk Jan 23, 2025
fd9d7ae
Address some http://errorprone.info/bugpattern/DistinctVarargsChecker…
cpovirk Jan 24, 2025
f062268
Remove obsolete claim that our internal Android tests skip anything w…
cpovirk Jan 25, 2025
1d3cbf8
Mark test-suite-builder suites and related code as `@AndroidIncompati…
cpovirk Jan 25, 2025
ff27805
Bump github/codeql-action in the github-actions group
dependabot[bot] Jan 27, 2025
e3e1ec5
Recommend `Arrays::compareUnsigned` to users of `UnsignedBytes.lexico…
cpovirk Jan 27, 2025
c876717
Stop running `StackOverflowError` tests under Android.
cpovirk Jan 29, 2025
83692e7
More and newer Javadoc links.
cpovirk Jan 30, 2025
12b2ec9
Remove some redundancies.
cpovirk Jan 30, 2025
6baae9f
Bump the github-actions group with 2 updates
dependabot[bot] Feb 3, 2025
a015c53
Internal Change
tanx16 Feb 3, 2025
f5fa4ea
Use string concatenation instead of `String.format`.
cpovirk Feb 3, 2025
453549c
Run a test under more environments.
cpovirk Feb 4, 2025
a3500eb
Add `image/avif` to `MediaType`.
java-team-github-bot Feb 6, 2025
7719744
Make `Atomic*FieldUpdater` fields `static` for better performance.
cpovirk Feb 6, 2025
57ec95c
Throw `StackOverflowError` manually instead of triggering a real stac…
cpovirk Feb 7, 2025
ca73f71
Recommend `Arrays::compareUnsigned` also for `int` and `long` arrays.
Stephan202 Feb 9, 2025
8ea070f
Disable two assertions for j2kt that are only passing by accident
martinkretzschmar Feb 10, 2025
5b19523
Bump github/codeql-action in the github-actions group
dependabot[bot] Feb 10, 2025
ccd06f2
Avoid mocking java.lang.Runtime
cushon Feb 10, 2025
4c6211e
Change snapshot version numbers to begin with a number.
sgammon Feb 11, 2025
20732ff
Suppress some https://errorprone.info/bugpattern/EnumOrdinal warnings.
cpovirk Feb 11, 2025
96cbfca
Partially enable ListeningScheduledExecutorService for j2kt (omitting…
stefanhaustein Feb 11, 2025
f95fa15
Address some https://errorprone.info/bugpattern/RedundantOverride war…
cpovirk Feb 11, 2025
9f771f6
Fix some https://errorprone.info/bugpattern/NotJavadoc warnings.
cpovirk Feb 11, 2025
f2bd540
Add `@CanIgnoreReturnValue`, or suppress where we shouldn't.
cpovirk Feb 11, 2025
c282d6a
Use _more_ lambdas.
cpovirk Feb 11, 2025
16d1e07
Standardize annotations on `serialVersionUID` fields.
cpovirk Feb 11, 2025
45f57f3
Apply InlineMe, or suppress where appropriate.
cpovirk Feb 12, 2025
d650068
Address some https://errorprone.info/bugpattern/YodaCondition warnings.
cpovirk Feb 12, 2025
96aec22
Address some https://errorprone.info/bugpattern/JdkObsolete warnings.
cpovirk Feb 12, 2025
cf77dac
Enable additional methods in MoreExecutors for J2kt-native
stefanhaustein Feb 12, 2025
89a6d25
Address assorted warnings for Error Prone, Android Lint, etc.
cpovirk Feb 12, 2025
287c701
Modularize `failureaccess`.
sgammon Feb 12, 2025
39b39d4
Use `@Serial` on `serialVersionUID` fields.
cpovirk Feb 12, 2025
b6c232c
Suppress some https://errorprone.info/bugpattern/UndefinedEquals warn…
cpovirk Feb 12, 2025
d0c23aa
Suppress some https://errorprone.info/bugpattern/NullableOptional war…
cpovirk Feb 12, 2025
cbf6f7f
Suppress some https://errorprone.info/bugpattern/CollectionUndefinedE…
cpovirk Feb 12, 2025
8df849d
Address https://errorprone.info/bugpattern/EscapedEntity warnings.
cpovirk Feb 13, 2025
5d336db
Withdraw usages of `java.io.Serial` from the external repo.
cpovirk Feb 13, 2025
740d8bd
Fix a few Javadoc warnings.
cpovirk Feb 13, 2025
1769a85
Internal change.
cpovirk Feb 14, 2025
46ce527
Truthify `escape` tests.
cpovirk Feb 18, 2025
7d7cc7d
Address a couple nullness errors.
cpovirk Feb 18, 2025
7ec362e
Temporarily withdraw `image/avif` from `MediaType`.
cpovirk Feb 18, 2025
688ad56
Fix some https://errorprone.info/bugpattern/AnnotationPosition warnings.
cpovirk Feb 19, 2025
7d73105
Mention `ExecutorService.close()` as a slightly different alternative…
cpovirk Feb 19, 2025
c4965e4
Fix some https://errorprone.info/bugpattern/UnnecessaryFinal warnings.
cpovirk Feb 19, 2025
ec82638
Revert commit 032e2f92 “Workaround bad J2KT/Kotlin smartcast interact…
martinkretzschmar Feb 20, 2025
a5a02ae
Change snapshot version numbers to begin with a _bigger_ number.
cpovirk Feb 20, 2025
60ba1ab
Reduce scope of suppressions in `Abstract*Future` classes, and make t…
cpovirk Feb 20, 2025
ba42c96
Update `TableCollectorsTest` for compatibility with J2KT.
java-team-github-bot Feb 20, 2025
2dd82ad
Refactor the main `AbstractFuture` implementation to prepare for usin…
cpovirk Feb 21, 2025
b15c23f
Use most of the main `AbstractFuture` implementation from J2KT and fr…
cpovirk Feb 21, 2025
8f6f4b3
Assorted cleanups noticed after recent `AbstractFuture` [changes](htt…
cpovirk Feb 21, 2025
2076b8e
Address more Error Prone warnings.
cpovirk Feb 21, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
99 changes: 99 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
name: Bug Report
description: Something is not working as expected
labels: ["type=defect"]
body:
- type: markdown
attributes:
value: >
Thank you for filing a bug report. Please help us identify and resolve the bug by filling
out the following fields. Before we begin, please make sure that the bug is still present in
the [latest](https://github.com/google/guava/releases/latest) version of Guava available.
If it's already fixed in the latest version of Guava, then please just update your Guava
version instead.

- type: input
attributes:
label: Guava Version
description: Which version of Guava are you using?
placeholder: e.g., 33.2.1-jre
validations:
required: true

- type: textarea
attributes:
label: Description
description: Please describe the issue you encountered.
validations:
required: true

- type: textarea
attributes:
label: Example
description: >
Please provide a [Short, Self Contained, Correct (Compilable), Example](http://sscce.org/)
demonstrating the bug.
render: java
validations:
required: true

- type: textarea
attributes:
label: Expected Behavior
description: What did you expect to happen?
validations:
required: true

- type: textarea
attributes:
label: Actual Behavior
description: What actually happened?
validations:
required: true

- type: dropdown
attributes:
label: Packages
description: If this issue is package-specific, then please select the relevant packages.
multiple: true
options:
- com.google.common.annotations
- com.google.common.base
- com.google.common.cache
- com.google.common.collect
- com.google.common.escape
- com.google.common.eventbus
- com.google.common.graph
- com.google.common.hash
- com.google.common.io
- com.google.common.math
- com.google.common.net
- com.google.common.primitives
- com.google.common.reflect
- com.google.common.testing
- com.google.common.util.concurrent

- type: dropdown
attributes:
label: Platforms
description: If this issue is platform-specific, then please select the relevant platforms.
multiple: true
options:
- Android
- GWT
- Java 8
- Java 11
- Java 17
- Java 21

- type: checkboxes
attributes:
label: Checklist
options:
- label: >
I agree to follow the
[code of conduct](https://github.com/google/.github/blob/master/CODE_OF_CONDUCT.md).
required: true
- label: >
I can reproduce the bug with the
[latest](https://github.com/google/guava/releases/latest) version of Guava available.
required: true
156 changes: 156 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_addition_request.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
name: Feature Addition Request
description: I want to add a new feature
labels: ["type=addition"]
body:
- type: markdown
attributes:
value: >
Filing feature requests is one of the most popular ways to contribute to Guava.


Be aware, though: most feature requests are not accepted, even if they're suggested by
a full-time Guava team member. [Feedback](https://stackoverflow.com/a/4543114) from our
users indicates that they really appreciate Guava's high power-to-weight ratio. It's
important to us to keep Guava as easy to use and understand as we can. That means boiling
features down to compact but powerful abstractions, and controlling feature bloat carefully.


Guava's main yardstick for evaluating proposed features can be summed up as [utility times
ubiquity](https://github.com/google/guava/wiki/PhilosophyExplained#utility-times-ubiquity).


#### Utility: compare with alternatives


There is always *some* alternative to adding a new feature to Guava, even if it's just
forking Guava yourself.


We want to see that new features have some significant advantage over the alternatives.
These advantages can take
[many forms](https://github.com/google/guava/wiki/PhilosophyExplained#utility), but taking
the time to discuss them in detail will make it much clearer why this feature should be
added to Guava.


Please fill out the following fields to give us a better understanding of your proposed
feature and its potential value for other Guava users.

- type: textarea
attributes:
label: 1. What are you trying to do?
validations:
required: true

- type: textarea
attributes:
label: 2. What's the best code you can write to accomplish that without the new feature?
validations:
required: true

- type: textarea
attributes:
label: 3. What would that same code look like if we added your feature?
validations:
required: true

- type: markdown
attributes:
value: >
Comparing two approaches to a use case side by side can make it easier to examine the
differences between them.


Additionally, it's very useful to us if you can provide a "straw API" &mdash; what the
method signatures would look like, for example, even if the method and class names are still
in flux. This can make the feature you're suggesting much clearer to us.

- type: textarea
attributes:
label: (Optional) What would the method signatures for your feature look like?
placeholder: |
e.g.,
public static <E> ImmutableList<E> of();
public static <E> ImmutableList<E> of(E element);
public static <E> ImmutableList<E> of(E e1, E e2);
...
render: java
validations:
required: false

- type: markdown
attributes:
value: >
#### Ubiquity: provide concrete use cases


Did you *actually* encounter the need for this feature in a real-world scenario, or is it
just a feature that seems like a sensible addition to Guava?


Before new features get added to Guava, we really want to be sure that it's for a use case
that actually comes up in the real world. We want to hear the real-world use case so the
community can discuss and debate whether this feature is actually the *best* way to address
the real use case, or whether or not a different abstraction might be more appropriate.


It's okay if you can't provide complete context on a use case. We understand if you are not
able to discuss the full details of what you're working on.


But Guava aims to provide features that are useful across boundaries of projects, companies,
or even industries &mdash; utilities useful for a sizable proportion of all Java programmers
everywhere. If you can give enough detail such that any of us can imagine coming across
a similar need in our own work, that's extremely helpful in studying how broadly useful the
feature will be.

- type: textarea
attributes:
label: Concrete Use Cases
description: Please provide use cases that actually came up in the real world.
validations:
required: true

- type: dropdown
attributes:
label: Packages
description: Please select all of the packages that are relevant to this feature request.
multiple: true
options:
- com.google.common.annotations
- com.google.common.base
- com.google.common.cache
- com.google.common.collect
- com.google.common.escape
- com.google.common.eventbus
- com.google.common.graph
- com.google.common.hash
- com.google.common.io
- com.google.common.math
- com.google.common.net
- com.google.common.primitives
- com.google.common.reflect
- com.google.common.testing
- com.google.common.util.concurrent

- type: checkboxes
attributes:
label: Checklist
options:
- label: >
I agree to follow the
[code of conduct](https://github.com/google/.github/blob/master/CODE_OF_CONDUCT.md).
required: true
- label: >
I have read and understood the [contribution
guidelines](https://github.com/google/guava/wiki/HowToContribute#feature-requests).
required: true
- label: >
I have read and understood
[Guava's philosophy](https://github.com/google/guava/wiki/PhilosophyExplained), and
I strongly believe that this proposal aligns with it.
required: true
- label: >
I have visited the [idea graveyard](https://github.com/google/guava/wiki/IdeaGraveyard),
and did not see anything similar to this idea.
required: true
108 changes: 108 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_enhancement_request.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
name: Feature Enhancement Request
description: I want to make an existing feature better
labels: ["type=enhancement"]
body:
- type: markdown
attributes:
value: >
Filing feature requests is one of the most popular ways to contribute to Guava.


Be aware, though: most feature requests are not accepted, even if they're suggested by
a full-time Guava team member. [Feedback](https://stackoverflow.com/a/4543114) from our
users indicates that they really appreciate Guava's high power-to-weight ratio. It's
important to us to keep Guava as easy to use and understand as we can. That means boiling
features down to compact but powerful abstractions, and controlling feature bloat carefully.

- type: textarea
attributes:
label: API(s)
description: Which existing classes or methods do you want to improve?
placeholder: e.g., `com.google.common.collect.ImmutableList::of`
render: java
validations:
required: true

- type: textarea
attributes:
label: How do you want it to be improved?
validations:
required: true

- type: textarea
attributes:
label: Why do we need it to be improved?
validations:
required: true

- type: textarea
attributes:
label: Example
description: >
Please provide an example usage of the feature that would be different with the improvement.
render: java
validations:
required: true

- type: textarea
attributes:
label: Current Behavior
description: What does the feature currently do?
validations:
required: true

- type: textarea
attributes:
label: Desired Behavior
description: What do you want it to do instead?
validations:
required: true

- type: markdown
attributes:
value: >
Did you *actually* encounter the need for this enhancement in a real-world scenario, or does
it just seem like a sensible behavior for the feature to have?


Before we make significant changes to existing features in Guava, we really want to be sure
that it's for a use case that actually comes up in the real world. We want to hear the
real-world use case so the community can discuss and debate whether this feature is actually
the *best* way to address the real use case, or whether or not a different approach might be
more appropriate.


It's okay if you can't provide complete context on a use case. We understand if you are not
able to discuss the full details of what you're working on.


But Guava aims to provide functionality that is useful across boundaries of projects,
companies, or even industries &mdash; utilities useful for a sizable proportion of all Java
programmers everywhere. If you can give enough detail such that any of us can imagine coming
across a similar need in our own work, that's extremely helpful in studying how broadly
useful the proposed change will be.

- type: textarea
attributes:
label: Concrete Use Cases
description: Please provide use cases that actually came up in the real world.
validations:
required: true

- type: checkboxes
attributes:
label: Checklist
options:
- label: >
I agree to follow the
[code of conduct](https://github.com/google/.github/blob/master/CODE_OF_CONDUCT.md).
required: true
- label: >
I have read and understood the [contribution
guidelines](https://github.com/google/guava/wiki/HowToContribute#feature-requests).
required: true
- label: >
I have read and understood
[Guava's philosophy](https://github.com/google/guava/wiki/PhilosophyExplained), and
I strongly believe that this proposal aligns with it.
required: true
21 changes: 18 additions & 3 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,27 @@ updates:
# - package-ecosystem: "maven"
# directory: "/"
# schedule:
# interval: "daily"
# interval: "weekly"
# groups:
# dependencies:
# applies-to: version-updates
# patterns:
# - "*"
# - package-ecosystem: "maven"
# directory: "/android"
# schedule:
# interval: "daily"
# interval: "weekly"
# groups:
# dependencies:
# applies-to: version-updates
# patterns:
# - "*"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
interval: "weekly"
groups:
github-actions:
applies-to: version-updates
patterns:
- "*"
Loading