Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sprint-2/step-1 #6

Merged
merged 4 commits into from
Jan 28, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,11 @@ git checkout sprint-1/step-1
git checkout sprint-1/step-2
```
Были [замечания](https://github.com/miptleha/react-burger/pull/4) по загрузке данных с сервера, успешно их исправил, работу приняли и я смержил все в main ветку.

## Спринт 2
### Шаг 1
Данные перенесены в Context. Заказ отправляется на сервер.
```
git checkout sprint-2/step-1
```
[Замечания](https://github.com/miptleha/react-burger/pull/6) по изменениям в ветке
50 changes: 30 additions & 20 deletions src/components/app/app.jsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { useEffect, useState } from 'react';
import styles from './app.module.css';
import { useEffect, useState, useReducer } from 'react';
import { dataLoad } from '../../utils/dataLoad';
import { sumReducer, sumInitialValue } from '../../services/sum-reducer';
import { OrderContext } from '../../services/order-context';

import styles from './app.module.css';
import AppHeader from '../app-header/app-header';
import BurgerConstructor from '../burger-constructor/burger-constructor';
import BurgerIngredients from '../burger-ingredients/burger-ingredients';
Expand All @@ -14,15 +17,19 @@ function App() {

useEffect(() => {
dataLoad()
.then(data => {
setState({ data: data, isLoading: false, isError: false });
})
.catch(err => {
console.log('ошибка получения данных', err);
setState({ data: null, isLoading: false, isError: true });
});
.then(data => {
setState({ data: data, isLoading: false, isError: false });
})
.catch(err => {
console.log('ошибка получения данных', err);
setState({ data: null, isLoading: false, isError: true });
});
}, []);

const [bun, setBun] = useState(null);
const [ingredients, setIngredients] = useState([]);
const [sumState, sumDispatcher] = useReducer(sumReducer, sumInitialValue);

return (
<>
{(state.isLoading || state.isError) ? (
Expand All @@ -32,17 +39,20 @@ function App() {
</p>
</main>
) :
state.data && (
<>
<AppHeader />
<main className={styles.main}>
<div className={styles.inner}>
<BurgerIngredients data={state.data} />
<BurgerConstructor data={state.data} />
</div>
</main>
</>
)}
state.data && (
<>
<AppHeader />
<main className={styles.main}>
<div className={styles.inner}>
<OrderContext.Provider value={{data: state.data, bun, setBun,
ingredients, setIngredients, sumState, sumDispatcher}}>
<BurgerIngredients />
<BurgerConstructor />
</OrderContext.Provider>
</div>
</main>
</>
)}
</>
);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,25 @@
import { useState } from 'react';
import PropTypes from 'prop-types';
import { useState, useContext } from 'react';
import { CurrencyIcon, Button } from "@ya.praktikum/react-developer-burger-ui-components";
import styles from './burger-constructor-order.module.css';
import OrderDetails from '../order-details/order-details';
import { OrderContext } from '../../services/order-context';
import { orderCreate } from '../../utils/orderCreate';
import Modal from '../modal/modal';

function BurgerConstructorOrder({ sum, number }) {
function BurgerConstructorOrder() {
const [show, setShow] = useState(false);
const [number, setNumber] = useState('');
const { ingredients, sumState } = useContext(OrderContext);

function showOrder() {
setShow(true);
orderCreate(ingredients)
.then(num => {
setNumber(num);
setShow(true);
})
.catch(error => {
miptleha marked this conversation as resolved.
Show resolved Hide resolved
console.log(error);
});
}

function hideOrder() {
Expand All @@ -17,17 +28,16 @@ function BurgerConstructorOrder({ sum, number }) {

return (
<div className={`${styles.total} mr-4 mt-10`}>
<div className="text text_type_digits-medium mr-2 mb-1">{sum}</div>
<div className="text text_type_digits-medium mr-2 mb-1">{sumState.sum}</div>
<div className={`${styles['total-icon']} mr-10`}><CurrencyIcon type="primary" /></div>
<Button htmlType="button" type="primary" onClick={showOrder}>Оформить заказ</Button>
{show && <OrderDetails number={number} onClose={hideOrder} />}
{show && (
<Modal onClose={hideOrder}>
<OrderDetails number={number} />
</Modal>
)}
</div>
);
}

BurgerConstructorOrder.propTypes = {
sum: PropTypes.number.isRequired,
number: PropTypes.string.isRequired
}

export default BurgerConstructorOrder;
39 changes: 24 additions & 15 deletions src/components/burger-constructor/burger-constructor.jsx
Original file line number Diff line number Diff line change
@@ -1,18 +1,31 @@
import { useMemo } from 'react';
import PropTypes from 'prop-types';
import { useContext, useEffect } from 'react';
import styles from './burger-constructor.module.css';
import { dataPropTypes } from '../../utils/dataPropTypes';
import { BUN } from '../../utils/dataNames';
import { ConstructorElement, DragIcon } from '@ya.praktikum/react-developer-burger-ui-components';
import BurgerConstructorOrder from '../burger-constructor-order/burger-constructor-order';
import { OrderContext } from '../../services/order-context';

function BurgerConstructor() {

function BurgerConstructor({ data }) {
const list = useMemo(() => data.filter(item => item.type !== BUN), [data]);
const bun = useMemo(() => data.find(item => item.type === BUN), [data]);
const sum = useMemo(() => bun.price * 2 + list.reduce((sum, item) => sum += item.price, 0), [list, bun]);
const { data, bun, setBun, ingredients, setIngredients, sumDispatcher } = useContext(OrderContext);

return (
useEffect(() => {
const buns = data.filter(item => item.type === BUN);
setBun(buns[Math.floor(Math.random() * buns.length)]);

const list = data.filter(item => item.type !== BUN &&
Math.round(Math.random()) === 1);
setIngredients(list);
}, [data, setBun, setIngredients]);

useEffect(() => {
if (bun) {
const sum = bun.price * 2 + ingredients.reduce((sum, item) => sum += item.price, 0);
sumDispatcher({ type: 'set', value: sum });
}
}, [bun, ingredients, sumDispatcher]);

return bun && (
<section className={styles.section}>
<div className={`${styles.burger} mt-25 ml-4`}>
<ConstructorElement
Expand All @@ -24,9 +37,9 @@ function BurgerConstructor({ data }) {
extraClass={`${styles.ingredient} ml-8`}
/>
<ul className={`${styles.scroll} mt-4 mb-4`}>
{list.map((item, index) => (
{ingredients.map((item, index) => (
<li className={`${styles['list-item']} mt-4`} key={index}>
<span className={styles.draggable}><DragIcon type="primary" /></span>
<DragIcon type="primary" />
<ConstructorElement
text={item.name}
price={item.price}
Expand All @@ -46,13 +59,9 @@ function BurgerConstructor({ data }) {
/>
</div>

<BurgerConstructorOrder sum={sum} number="034536" />
<BurgerConstructorOrder />
</section>
);
}

BurgerConstructor.propTypes = {
data: PropTypes.arrayOf(dataPropTypes.isRequired).isRequired
}

export default BurgerConstructor;
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,10 @@
.list-item {
display: flex;
align-items: center;
cursor: move;
}

.ingredient {
background: var(--background);
}

.draggable {
cursor: grabbing;
}
31 changes: 24 additions & 7 deletions src/components/burger-ingredients-item/burger-ingredients-item.jsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,26 @@
import { useState } from 'react';
import PropTypes from 'prop-types';
import { useState, useContext, useMemo } from 'react';
import { dataPropTypes } from '../../utils/dataPropTypes';
import { OrderContext } from '../../services/order-context';
import { BUN } from '../../utils/dataNames';

import styles from './burger-ingredients-item.module.css';
import { CurrencyIcon, Counter } from '@ya.praktikum/react-developer-burger-ui-components';
import IngredientDetails from '../ingredient-details/ingredient-details';
import Modal from '../modal/modal';

function BurgerIngredientItem({ item, count }) {
function BurgerIngredientItem({ item }) {
const [show, setShow] = useState(false);
const { ingredients, bun } = useContext(OrderContext);

const count = useMemo(() => {
if (item.type === BUN && bun) {
return bun._id === item._id ? 1 : 0;
}
else {
const list = ingredients.filter(i => i._id === item._id);
return list.length;
}
}, [item, bun, ingredients]);

function showDialog() {
setShow(true);
Expand All @@ -25,15 +39,18 @@ function BurgerIngredientItem({ item, count }) {
<CurrencyIcon type="primary" />
</div>
<div className={`${styles.title} text text_type_main-default`}>{item.name}</div>
{count && count > 0 ? <Counter count={count} size="default" extraClass={styles.count} /> : undefined}
{show && <IngredientDetails item={item} onClose={hideDialog} />}
{count > 0 && <Counter count={count} size="default" extraClass={styles.count} />}
{show && (
<Modal caption="Детали ингридиента" onClose={hideDialog}>
miptleha marked this conversation as resolved.
Show resolved Hide resolved
<IngredientDetails item={item} />
</Modal>
)}
</li>
);
}

BurgerIngredientItem.propTypes = {
item: dataPropTypes.isRequired,
count: PropTypes.number
item: dataPropTypes.isRequired
}

export default BurgerIngredientItem;
16 changes: 6 additions & 10 deletions src/components/burger-ingredients/burger-ingredients.jsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { useMemo, useRef } from 'react';
import PropTypes from 'prop-types';
import { useContext, useMemo, useRef } from 'react';
import styles from './burger-ingredients.module.css';
import { BUN, SAUCE, MAIN, names } from '../../utils/dataNames';
import { dataPropTypes } from '../../utils/dataPropTypes';
import BurgerIngredientsTabs from '../burger-ingredients-tabs/burger-ingredients-tabs';
import BurgerIngredientsItem from '../burger-ingredients-item/burger-ingredients-item';
import { OrderContext } from '../../services/order-context';

function BurgerIngredients({ data }) {
function BurgerIngredients() {
const { data } = useContext(OrderContext);
const groups = useMemo(() => {
let res = {};
res[BUN] = data.filter(i => i.type === BUN);
Expand Down Expand Up @@ -34,8 +34,8 @@ function BurgerIngredients({ data }) {
<div key={typeIndex}>
<h2 className="text text_type_main-medium mt-2" ref={headers[type]}>{names[type]}</h2>
<ul className={styles['group-content']}>
{groups[type].map((item, index) => (
<BurgerIngredientsItem key={type + index} item={item} count={index === 0 ? 1 : 0}/>
{groups[type].map((item) => (
<BurgerIngredientsItem key={item._id} item={item}/>
))}
</ul>
</div>
Expand All @@ -45,8 +45,4 @@ function BurgerIngredients({ data }) {
);
}

BurgerIngredients.propTypes = {
data: PropTypes.arrayOf(dataPropTypes.isRequired).isRequired
}

export default BurgerIngredients;
11 changes: 4 additions & 7 deletions src/components/ingredient-details/ingredient-details.jsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import PropTypes from 'prop-types';
import styles from './ingredient-details.module.css';
import Modal from '../modal/modal';
import { dataPropTypes } from '../../utils/dataPropTypes';

function IngredientDetails({ item, onClose }) {
function IngredientDetails({ item }) {
return (
<Modal caption="Детали ингридиента" onClose={onClose}>
<>
<img className={`${styles.image} mb-4`} src={item.image_large} alt="Изображение ингридиента" />
<p className={`${styles.name} text-center text text_type_main-medium mb-8`}>{item.name}</p>
<div className={`${styles.detail} mb-15`}>
Expand All @@ -26,13 +24,12 @@ function IngredientDetails({ item, onClose }) {
<div className="text-center text text_type_digits-default text_color_inactive">{item.carbohydrates}</div>
</div>
</div>
</Modal>
</>
);
}

IngredientDetails.propTypes = {
item: dataPropTypes.isRequired,
onClose: PropTypes.func.isRequired
item: dataPropTypes.isRequired
}

export default IngredientDetails;
2 changes: 1 addition & 1 deletion src/components/modal/modal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function Modal({ caption, children, onClose }) {

Modal.propTypes = {
caption: PropTypes.string,
children: PropTypes.arrayOf(PropTypes.element),
children: PropTypes.element.isRequired,
onClose: PropTypes.func.isRequired
}

Expand Down
12 changes: 5 additions & 7 deletions src/components/order-details/order-details.jsx
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
import PropTypes from 'prop-types';
import img from '../../images/done.png';
import Modal from '../modal/modal';
import styles from './order-details.module.css';

function OrderDetails({ number, onClose }) {
function OrderDetails({ number }) {
return (
<Modal onClose={onClose}>
<p className={`${styles["order-number"]} text text_type_digits-large mb-8`}>{number}</p>
<>
<p className={`${styles["order-number"]} text text_type_digits-large mb-8 text-center`}>{number}</p>
<p className="text text_type_main-medium mb-15 text-center">идентификатор заказа</p>
<img src={img} className={`${styles.image} mb-15 text-center`} alt="Заказ принят" />
<p className="text text_type_main-default mb-2 text-center">Ваш заказ начали готовить</p>
<p className={`${styles["last-p"]} text text_type_main-default text_color_inactive mb-30 text-center`}>Дождитесь готовности на орбитальной станции</p>
</Modal>
</>
);
}

OrderDetails.propTypes = {
number: PropTypes.string.isRequired,
onClose: PropTypes.func.isRequired
number: PropTypes.number.isRequired
}

export default OrderDetails;
3 changes: 3 additions & 0 deletions src/services/order-context.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { createContext } from 'react';

export const OrderContext = createContext();
12 changes: 12 additions & 0 deletions src/services/sum-reducer.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
export const sumInitialValue = { sum: 0 };

export function sumReducer(state, action) {
switch (action.type) {
case 'set':
return { sum: action.value };
case 'reset':
return sumInitialValue;
default:
throw Error(`Неверное действие: ${action.type}`);
}
}
Loading