Sprint 5/step 1 #12
Merged
Sprint 5/step 1 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andryxxa93
suggested changes
Mar 19, 2023
There was a problem hiding this comment.
Здравствуйте! Отличная работа 👍
Что понравилось:
- Добавили проверку успешности запроса
- Реализовали раздельное хранение данных полученных по сокету
- Хорошо типизировали хранилище
Что необходимо исправить:
- Повторяющиеся в заказе ингредиенты необходимо суммировать. Посмотрите пожалуйста как в фигме.
В pull request вы так же найдете комментарии с рекомендациями как можно улучшить код. Их делать не обязательно, однако в будущем они могут помочь избежать ошибок и сделать код лучше.
Удачных правок!
andryxxa93
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.