This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Fix nav and breadcrumbs for objects, findings and tasks #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar92
reviewed
Jan 25, 2023
|
@ammar92 thanks for pointing it out. The list showed only green marks, and I wasn't aware that I had to scroll nor did I read the RED marked text (doh). Will fix it asap :) |
underdarknl
approved these changes
Jan 26, 2023
underdarknl
deleted the
feature/fix-menu-in-combination-with-breadcrumbs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all occurrences that were reported in minvws/nl-kat-coordination#346
Tasks page had previously "objects > tasks" as breadcrumbs. Currently:
Objects page had previously "findings > object name" as breadcrumbs. Currently:
Findings page had previously "findings" and "objects" as highlighted menu items. Currently:
