Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Removed old references to miauw and signal #179

Merged
merged 4 commits into from
Jan 26, 2023

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented Jan 23, 2023

Changes

Removed some dead code and references to Miauw and Signal

Proof

Searching miauw and signal using find usages option and grep yields no results anymore.

Good to know

  • Does this PR introduce or depend on API-incompatible changes? If yes: what do other users/developers need to do or confirm before merging?
    • No
  • Does this PR depend on a specific version of a library?
    • No
  • Does this PR require config, setup, or .env changes?
    • Yes, settings related to miauw can be removed safely

Checklist for author(s):

  • This PR comes from a feature or hotfix branch, in line with our git branching strategy;
  • I have squashed all commits before merging this PR;
  • This PR is "bite-sized" and only focuses on a single issue, problem, or feature;
  • If a non-trivial PR: This PR is properly linked to an issue on the project board;
  • If a non-trivial PR: I have added screenshots or some other proof that my code does what it is supposed to do;
  • I am not reinventing the wheel: there is no high-quality library that already has this feature;
  • I have changed the example .env files if I added, removed, or changed any config options, and I have informed others that they need to modify their .env files if required;
  • I have performed a self-review of my own code;
  • I have commented my code, particularly in hard-to-understand areas;
  • I have made corresponding changes to the documentation, if necessary;
  • I have written unit, integration, and end-to-end tests for the change that I made;

@ammar92 ammar92 requested a review from a team as a code owner January 23, 2023 14:29
rocky/views/organization_edit.py Outdated Show resolved Hide resolved
ammar92 and others added 2 commits January 25, 2023 16:15
Signed-off-by: ammar <[email protected]>
Donnype
Donnype previously approved these changes Jan 25, 2023
# Conflicts:
#	tools/miauw_helpers.py
@underdarknl underdarknl merged commit 673371d into main Jan 26, 2023
@underdarknl underdarknl deleted the fix/remove-references-to-miauw branch January 26, 2023 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants