This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # rocky/templates/oois/ooi_list.html
# Conflicts: # rocky/templates/forms/widgets/checkbox_group_table.html
TwistMeister
approved these changes
Jan 18, 2023
underdarknl
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please create a new ticket for refactoring this into a method on the user or OOI model instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backend checks on current permissions setup for changing scan levels. This is the best I could do in a short time but could use a better setup (either mixins or using django permissions).
Issue ticket number and link
Popped up in #86.
Proof
One of the pages after removing an indemnification:
![image](https://user-images.githubusercontent.com/46660228/212968534-835e96e9-e147-4ccc-959f-c02c0b508984.png)
Checklist for author(s):
feature
orhotfix
branch, in line with our git branching strategy;.env
files if I added, removed, or changed any config options, and I have informed others that they need to modify their.env
files if required;