[OpenKAT v1.5] Fix boefje detail checkboxes function at scan oois

[Rieven]

Changes

• Fix: Checkbox in table head does not select all OOIS
• Fix: Checkbox Show objects that don't meet the Boefjes scan level triggers table view with objects below boefje scan level

Issue ticket number and link

https://github.com/minvws/nl-rt-tim-abang-rocky/issues/835

Proof

[underdarknl]

taalfoutje

[TwistMeister]

@Rieven please read my comment on the original issue about the "show objects that don't meet the boefjes scan level" checkbox (https://github.com/minvws/nl-rt-tim-abang-rocky/issues/835).

The warning that was shown isn't really the issue here. The info text beneath the header and the warning after checking the checkbox where carefully considered by @HeleenSG and me and worked in conjunction with each other as intended. What's wrong is the box getting unchecked after the page reloads and the user not being informed about why the list isn't complemented (when there are no additional objects to show). Please discard the changes on file "objects_to_scan.html" since that isn't the issue here and the behaviour and those text were carefully chosen.

[underdarknl]

The checkbox on 0:22 in the movie is still unchecked after the refresh., It should be on in that state.

[Rieven]

@Rieven please read my comment on the original issue about the "show objects that don't meet the boefjes scan level" checkbox (minvws/nl-rt-tim-abang-rocky#835).

Fixed in commit: 4258c85

[Darwinkel]

This is perfect!

As an end-user, it is now much clearer what is happening. The user flow to override and set a higher clearance level is especially nice.

Approved!

Stale review