Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Feature/scan level filtering #21

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Feature/scan level filtering #21

merged 2 commits into from
Jan 5, 2023

Conversation

Lisser
Copy link
Contributor

@Lisser Lisser commented Dec 16, 2022

Changes

Changes scan-level filtering from filtering on a scale with operators (eq, le, ge, etc) to filtering based on members of an enumated set (L0, L1, L2, L3, L4).

Issue ticket number and link

Corresponding Rocky PR:

Proof

Extra instructions for others

Test with minvws/nl-kat-rocky#82

  • Does this PR introduce or depend on API-incompatible changes? If yes: what do other users/developers need to do or confirm before merging?
    • Yes. Breaks previous API scan-profile filter
  • Does this PR depend on a specific version of a library?
  • Does this PR depend on any other pending PR's?
  • Does this PR require config, setup, or .env changes?
    -->

Checklist for author(s):

  • This PR comes from a feature or hotfix branch, in line with our git branching strategy;
  • This PR is "bite-sized" and only focuses on a single issue, problem, or feature;
  • If a non-trivial PR: This PR is properly linked to the project board (either directly or via an issue);
  • If a non-trivial PR: I have added screenshots or some other proof that my code does what it is supposed to do;
  • I am not reinventing the wheel: there is no high-quality library that already has this feature;
  • I have changed the example .env files if I added, removed, or changed any config options, and I have informed others that they need to modify their .env files if required;
  • I have performed a self-review of my own code;
  • I have commented my code, particularly in hard-to-understand areas;
  • I have made corresponding changes to the documentation, if necessary;
  • I have written unit, integration, and end-to-end tests for the change that I made;
## Checklist for functional reviewer(s):
- [ ] If a non-trivial PR: This PR is properly linked to an issue on the project board;
- [ ] I have checked out this branch, and successfully ran `make kat`;
- [ ] I have ran `make test-rf` and all end-to-end Robot Framework tests pass;
- [ ] I confirmed that the PR's advertised `feature` or `hotfix` works as intended;
- [ ] I confirmed that there are no unintended functional regressions in this branch;

### What works:
* _bullet point + screenshot (if useful) per tested functionality_

### What doesn't work:
* _bullet point + screenshot (if useful) per tested functionality_

### Bug or feature?:
* _bullet point + screenshot (if useful) if it is unclear whether something is a bug or an intended feature._
## Checklist for code reviewer(s):
- [ ] The code passes the CI tests and linters;
- [ ] The code does not bypass authentication or security mechanisms;
- [ ] The code does not introduce any dependency on a library that has not been properly vetted;
- [ ] The code does not violate Model-View-Template and our other architectural principles;
- [ ] The code contains docstrings, comments, and documentation where needed;
- [ ] The code prioritizes readability over performance where appropriate;
- [ ] The code conforms to our agreed coding standards.

@Lisser Lisser requested a review from a team as a code owner December 16, 2022 10:57
@github-actions
Copy link

github-actions bot commented Dec 16, 2022

File Coverage
All files 66%
bits/definitions.py 64%
bits/runner.py 56%
bits/https_availability/https_availability.py 93%
bits/oois_in_headers/oois_in_headers.py 72%
octopoes/api/api.py 87%
octopoes/api/router.py 43%
octopoes/core/app.py 71%
octopoes/core/service.py 59%
octopoes/events/events.py 96%
octopoes/events/manager.py 65%
octopoes/models/__init__.py 79%
octopoes/models/datetime.py 66%
octopoes/models/exception.py 83%
octopoes/models/origin.py 70%
octopoes/models/path.py 99%
octopoes/models/types.py 95%
octopoes/models/ooi/certificate.py 96%
octopoes/models/ooi/findings.py 93%
octopoes/models/ooi/network.py 97%
octopoes/models/ooi/service.py 91%
octopoes/models/ooi/software.py 71%
octopoes/models/ooi/web.py 81%
octopoes/models/ooi/dns/records.py 93%
octopoes/models/ooi/dns/zone.py 82%
octopoes/repositories/ooi_repository.py 40%
octopoes/repositories/origin_parameter_repository.py 52%
octopoes/repositories/origin_repository.py 52%
octopoes/repositories/scan_profile_repository.py 45%
octopoes/xtdb/client.py 38%
octopoes/xtdb/query_builder.py 69%
octopoes/xtdb/related_field_generator.py 73%
tests/conftest.py 91%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 5d08c76

@Lisser Lisser changed the title implement discrete scan-levels Feature/scan level filtering Dec 16, 2022
Copy link
Contributor

@underdarknl underdarknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Probably needs to be merged in tandem with rocky changes.

@dekkers dekkers merged commit f683d3c into main Jan 5, 2023
@dekkers dekkers deleted the feature/discrete-scan-levels branch January 5, 2023 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants