Explicitely use the fork context for multiprocessing to fix running boefjes on macOS #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamblitz
approved these changes
Sep 24, 2024
ammar92
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Since I haven't encountered this issue (yet?) and there's no context, I don't have much to add. But can you elaborate a bit more about what this exactly fixes? What specific differences in behavior do we see when running this in a containerized environment on MacOS?
|
@ammar92 Since MacOS uses a spawn by default instead of a fork, apparently the system tries to pickle the arguments of the process's target (start_working) and fails to do that. Hence @noamblitz was experiencing issues starting the boefje worker and API outside of Docker. |
|
dns-records and nmap-tcp work succesfully from inside the docker-boefjes. Tested on Ubuntu 22.04.4 LTS |
underdarknl
approved these changes
Sep 26, 2024
underdarknl
deleted the
fix/explicitely-use-fork-for-multiprocessing-for-macos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds no functionality but fixes a bug experienced by @noamblitz.
Note that, as I just noticed, from Python 3.14 onward we would have to do this anyways or have a new bug:
Issue link
Demo
QA notes
Please run make kat and verify the boefjes still run properly!
Code Checklist
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.