Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button style #3565

Merged
merged 3 commits into from
Sep 26, 2024
Merged

fix: button style #3565

merged 3 commits into from
Sep 26, 2024

Conversation

HeleenSG
Copy link
Contributor

@HeleenSG HeleenSG commented Sep 19, 2024

Changes

  • Hover state border 1px instead of 2px.
  • Grey border instead of colored borders
  • Check if border color is correct

Adds destructive ghost button styling

Issue link

Closes #3040

Demo

Different states: Destructive ghost button with hover. Hover state on ghost button.
Screenshot 2024-09-19 at 15 04 26
Screenshot 2024-09-19 at 15 04 23
Screenshot 2024-09-19 at 15 04 29

QA notes


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@HeleenSG HeleenSG self-assigned this Sep 19, 2024
@HeleenSG HeleenSG marked this pull request as ready for review September 19, 2024 13:08
@HeleenSG HeleenSG requested a review from a team as a code owner September 19, 2024 13:08
@HeleenSG HeleenSG merged commit ef53177 into main Sep 26, 2024
10 checks passed
@HeleenSG HeleenSG deleted the fix/button-style branch September 26, 2024 15:23
@HeleenSG HeleenSG restored the fix/button-style branch September 26, 2024 15:24
@HeleenSG HeleenSG deleted the fix/button-style branch September 26, 2024 15:24
@underdarknl
Copy link
Contributor

Did we need more commits on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Design: add 'clear all' possibility to multiselect filter dropdown component
3 participants