Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "name" field for plugins mandatory #3471

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Sep 5, 2024

Changes

A follow up on #3444 where we make the name field required at the model level as well.

Issue link

This should fix the issue with the database models where the name is not nullable, and make sure we can use the name field for human readables now that we will start generating UUIDs for plugins ids. This PR also adds some names that were still missing.

Demo

QA notes

This does not add features, please verify that the boefjes and normalizers run properly still!


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype requested a review from a team as a code owner September 5, 2024 09:09
@Donnype Donnype changed the title Make the "name" field for plugins required Make the "name" field for plugins mandatory Sep 5, 2024
@Donnype Donnype self-assigned this Sep 5, 2024
@Donnype Donnype added bug Something isn't working boefjes Issues related to boefjes labels Sep 5, 2024
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

All the enabled boefjes and normalizers run as expected.

What doesn't work:

n/a

Bug or feature?:

n/a

@underdarknl underdarknl merged commit a0c48c8 into main Sep 9, 2024
9 checks passed
@underdarknl underdarknl deleted the fix/make-plugin-name-required branch September 9, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boefjes Issues related to boefjes bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants