Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Boefje #3400

Merged
merged 49 commits into from
Sep 11, 2024
Merged

Add new Boefje #3400

merged 49 commits into from
Sep 11, 2024

Conversation

madelondohmen
Copy link
Contributor

@madelondohmen madelondohmen commented Aug 23, 2024

Changes

This PR makes it possible for an admin to add new Boefjes.

The following specifications have been added:

  • New "Add boefje" button on Boefjes-page
  • New "Boefje setup" page with a form
  • Updated "Boefje details" page
  • Permission set to admin only

Note: The lay-out of the form has been updated to meet the design. This will cause all forms in KAT to be updated. This is a side effect of this PR. However, this is desirable.

Issue link

Closes #3367
Closes #1628

Demo

  • New "Add boefje" button on Boefjes-page:
    afbeelding

  • New "Boefje setup" page with a form:
    afbeelding

  • Updated "Boefje details" page:
    afbeelding

  • Boefje added to overview page:
    afbeelding

QA notes

Try to add a new Boefje by clicking the "Add Boefje" button.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen madelondohmen self-assigned this Aug 23, 2024
@madelondohmen madelondohmen marked this pull request as ready for review August 26, 2024 15:13
@madelondohmen madelondohmen requested a review from a team as a code owner August 26, 2024 15:13
@underdarknl underdarknl added this to the OpenKAT v1.18 milestone Aug 27, 2024
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Works! Newly added boefje, with and without arguments runs and the normalizer runs as well. Tested only for the nmap boefje.

What doesn't work:

N/a

Bug or feature?:

  • On the tasks list the uuid is shown for the newly added boefje instead of a user readable format. See the screenshot below. It would be nice to have this into a human readable format as well.

image

@madelondohmen madelondohmen mentioned this pull request Sep 4, 2024
9 tasks
@stephanie0x00 stephanie0x00 mentioned this pull request Sep 4, 2024
9 tasks
@underdarknl underdarknl merged commit 12fdb44 into main Sep 11, 2024
15 checks passed
@underdarknl underdarknl deleted the feature/add-new-boefje branch September 11, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating new boefjes Ability to add OCI image boefjes to Katalogus
6 participants