-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Boefje #3400
Merged
Merged
Add new Boefje #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppvg
reviewed
Aug 23, 2024
ppvg
reviewed
Aug 23, 2024
ppvg
reviewed
Aug 23, 2024
Closed
1 task
…y query the local repository Signed-off-by: Donny Peeters <[email protected]>
Donnype
reviewed
Sep 2, 2024
Checklist for QA:
What works:Works! Newly added boefje, with and without arguments runs and the normalizer runs as well. Tested only for the nmap boefje. What doesn't work:N/a Bug or feature?:
|
Signed-off-by: Donny Peeters <[email protected]>
underdarknl
approved these changes
Sep 11, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes it possible for an admin to add new Boefjes.
The following specifications have been added:
Note: The lay-out of the form has been updated to meet the design. This will cause all forms in KAT to be updated. This is a side effect of this PR. However, this is desirable.
Issue link
Closes #3367
Closes #1628
Demo
New "Add boefje" button on Boefjes-page:
![afbeelding](https://private-user-images.githubusercontent.com/99282220/360877888-70ecde42-91bb-4a3c-b1eb-9a443369cff6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDg5MTQsIm5iZiI6MTczOTU0ODYxNCwicGF0aCI6Ii85OTI4MjIyMC8zNjA4Nzc4ODgtNzBlY2RlNDItOTFiYi00YTNjLWIxZWItOWE0NDMzNjljZmY2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE1NTY1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxYjljZjE4ODJkMmNjNmFlZTMzZmUwNmYxMWYxNWI1ODE3YjkwODE2NmZlOTBmMzc1NTE0MjdkNjQ3YzcwNDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.p44Z51DvpRhoPKx2do99y0xMf295wl1v5XZW0vNxsEs)
New "Boefje setup" page with a form:
![afbeelding](https://private-user-images.githubusercontent.com/99282220/360878207-9b8397c3-df8d-4dc1-aae3-d7fb1963e4c6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDg5MTQsIm5iZiI6MTczOTU0ODYxNCwicGF0aCI6Ii85OTI4MjIyMC8zNjA4NzgyMDctOWI4Mzk3YzMtZGY4ZC00ZGMxLWFhZTMtZDdmYjE5NjNlNGM2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE1NTY1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcxODQ1NWQyNzQyZDU3NTViY2Y0YzU0ZTI0MTlkZjRhNjQ3ZTMxOTVhOWQxOWQ0NWM4MzYxMGJjMWM5Zjk5ODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.H39rIph3Jn-xwN2Uidi28vfX9HHl6HnZkUEnNMXxSbI)
Updated "Boefje details" page:
![afbeelding](https://private-user-images.githubusercontent.com/99282220/360880651-5ba5801a-37de-4f05-a10f-39355e9941d2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDg5MTQsIm5iZiI6MTczOTU0ODYxNCwicGF0aCI6Ii85OTI4MjIyMC8zNjA4ODA2NTEtNWJhNTgwMWEtMzdkZS00ZjA1LWExMGYtMzkzNTVlOTk0MWQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE1NTY1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI5NzkxYmExNWI4NzYxNWY4MTQ0N2IzNDQ4MjI0YzYwN2Y4ZDBiNWYzZWEyN2MyNThmYzE5ZDE3NjQyM2NkMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.tCzyXAZjGNtEOHuOimKdu74KJ4GD9gA-wd9Dv-Iuxas)
Boefje added to overview page:
![afbeelding](https://private-user-images.githubusercontent.com/99282220/360881943-116e5e57-93e8-4ef1-9bf9-9f20d9c2b26a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDg5MTQsIm5iZiI6MTczOTU0ODYxNCwicGF0aCI6Ii85OTI4MjIyMC8zNjA4ODE5NDMtMTE2ZTVlNTctOTNlOC00ZWYxLTliZjktOWYyMGQ5YzJiMjZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE1NTY1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIyNzI2MmRlNDRmNTYwNjA3M2EzZjFiZjU2MGNlYzNlYTkxYTE2YjNjNjI0NjgwNDc5ZmM4ZTc0OWJhNDMxYzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.tvbqvWo7Hl7jQs7bm76IW4mQ83Iwq9WZvoUXeqSioyM)
QA notes
Try to add a new Boefje by clicking the "Add Boefje" button.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.