RFC3161HashRepository accepts rfc3161_provider only as a string and Pydantic URLs are not strings anymore #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd pydantic URLs are not strings anymore.
underdarknl
approved these changes
Jul 23, 2024
dekkers
pushed a commit
that referenced
this pull request
Jul 23, 2024
…ydantic URLs are not strings anymore (#3281)
jpbruinsslot
added a commit
that referenced
this pull request
Jul 25, 2024
* fix/mula/new_boefjes: Add more tests Add additional thread safety test for the other caches Add thread safety tests Fix new boefjes issue feat: Updated color scheme (#3241) Bump sphinx from 7.4.6 to 7.4.7 (#3265) Fix rocky logging (#3288) Add XTDB list and rename method in origin tool (#3234) RFC3161HashRepository accepts rfc3161_provider only as a string and Pydantic URLs are not strings anymore (#3281)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bugfix that is rather trivial.
Issue link
Closes #3277
Demo
QA notes
To enable an rfc provider add these test values to your env, restart kat and make sure you can add an OOI (also see the issue description):
Code Checklist
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.