Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken token auth when 2FA is enabled #3260

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Jul 19, 2024

Changes

Fix broken token auth when 2FA is enabled.

Also add "API" to the "Token authentication" section heading so that the section is return if you search for "API".

Issue link

Closes #2872

QA notes

Enable 2FA and test that the REST API work again.


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner July 19, 2024 12:03
Copy link
Contributor

@underdarknl underdarknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ammar92
Copy link
Contributor

ammar92 commented Jul 24, 2024

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

  • I can access the REST API
    • Works with two-factor enabled
    • Works with two-factor disabled

@underdarknl underdarknl merged commit 3be68ac into main Jul 24, 2024
11 checks passed
@underdarknl underdarknl deleted the tokenauth-2fa-bug branch July 24, 2024 12:09
jpbruinsslot added a commit that referenced this pull request Jul 29, 2024
…r-queue

* feature/mula/storage-updates:
  Fix tests
  Update
  Update tests
  Fix mypy suggestions
  Refactor/ooi details (#3275)
  Raise Timeout Exception when only timeouts from DNS server (#3264)
  Fix broken token auth when 2FA is enabled (#3260)
  Restructure storage
dekkers added a commit that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization endpoint not functioning correctly with token
3 participants