Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no limit by default in the KATalogus plugin API #2921

Merged
merged 3 commits into from
May 8, 2024

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented May 7, 2024

Changes

A small default change to resolve the issue of not seeing all boefjes in a more future proof way.

Issue link

Closes #2724

Demo and QA notes

Should not change any current behavior and is therefore hard to QA. We should verify if the KATalogus is still working properly in Rocky perhaps.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype requested a review from a team as a code owner May 7, 2024 14:34
@underdarknl
Copy link
Contributor

Looks good to me :)

@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

The logs look fine, the katalogus can be reached and boefjes can be enabled. The boefjes in de katalogus contain the 'Produces/Relating' links and no failed tasks.

What doesn't work:

n/a

Bug or feature?:

n/a

@dekkers dekkers merged commit b8b5261 into main May 8, 2024
9 checks passed
@dekkers dekkers deleted the fix/katalogus-pagination branch May 8, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LIMIT = 100 in katalogus types.py disables normalizers past 100 count
5 participants