-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✏️ make findings more informative #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamblitz
previously approved these changes
Feb 16, 2023
Minimum allowed coverage is Generated by 🐒 cobertura-action against 811b586 |
underdarknl
approved these changes
Feb 20, 2023
Very nice, this has been on my todo list for a few months now, thanks for picking this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the
OOI_database_seed.json
and all its references to give more informative findings to the end-user.Issue ticket number and link
Related: #152
Proof
Extra instructions for others
Some findings exist only in the
OOI_database_seed.json
, implying that they are not used by any plugin. Examples are some SPF and IPV6 findings.Checklist for author(s):
feature
orhotfix
branch, in line with our git branching strategy;.env
files if I added, removed, or changed any config options, and I have informed others that they need to modify their.env
files if required;If a non-trivial PR: