Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove everything related to old crux #2403

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Remove everything related to old crux #2403

merged 2 commits into from
Jan 31, 2024

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Jan 30, 2024

Changes

  • All code related to crux and non-multinode XTDB has been removed and Octopoes will only support XTDB multinode.
  • The code has been updated to use xt/id instead of crux.db/id everywhere (as far as I can see crux.db/id is still supported by XTDB as backwards compatibility so that's why it was still working without problems in the few hardcoded places).
  • The option to run robotframework tests with crux has been deleted.
  • The robotframework tests have been rewritten to use multinode instead of standalone XTDB. I've also refactored it a bit to get rid of duplication in the test setup/teardown.
  • octopoes/docs/source/readme.md was an outdated duplicate of docs/source/developer_documentation/octopoes.md and has been removed.
  • All references to crux in the documentation and comments have been updated to XTDB and broken links to opencrux.com have been fixed.
  • Celery in the tests doesn't need to use celery beat so I disabled it, I hope this will contribute to making the robot tests more deterministic.

Issue link

Closes #2335


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner January 30, 2024 22:40
This will these changed Octopoes will only support XTDB multinode
Copy link
Contributor

@Donnype Donnype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup. If the tests say aye I say yay

@underdarknl underdarknl merged commit a7e7af0 into main Jan 31, 2024
35 checks passed
@underdarknl underdarknl deleted the remove-crux branch January 31, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove make -C octopoes rtest-crux and related
3 participants