Table captions #2217
Merged
Table captions #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underdarknl
reviewed
Dec 28, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <div class="horizontal-scroll"> | |||
| <table> | |||
| <caption class="visually-hidden">{% translate "Overzicht Handmatig gevrijwaarde gescande assets:" %}</caption> | |||
| <caption class="visually-hidden">{% translate "Declared scanned assets:" %}</caption> | |||
There was a problem hiding this comment.
This should just say:
"Selected assets", as its not limited to just declared assets if the user makes a different choice earlier on in the flow.
underdarknl
approved these changes
Dec 29, 2023
jpbruinsslot
added a commit
that referenced
this pull request
Jan 2, 2024
* main: Updated deploy-pages action (#2251) Bump msgpackr from 1.6.1 to 1.10.1 in /rocky (#2219) Add note about Debian packages to 1.14 release notes (#2234) Upgrade GitHub actions (#2235) Remove RPKI data files (#2228) Add 1.14 release notes (#2227) remove feature flag for reports. (#2226) Add multi organization report (#2209) Preselected OOIs for Reporting (#2208) Text changes OOI into Object (#2224) Adds the option to add chapter letters (#2225) Fix typos in aggregate report (#2168) Alert icons (#2221) Fix health endpoint scheduler (#2218) Table captions (#2217) Initial version of aggregate report appendix (#2212) add html entities escaping to normalizer results (#2211) Pdf and print styling (#2206) Adding recommendations to the aggregate report (#2210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the content of the captions as well. To make sure it matches the content of the table.
Changes
Please describe the essence of this PR in a few sentences. Mention any breaking changes or required configuration steps.
Issue link
Please add a link to the issue after "Closes". If there is no issue for this PR, please add it to the project board directly.
Closes ... #2189
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.