This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
[OpenKAT v1.6] Feature/multipart download #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from one boefje, while also using external supplied mime-types
…roduces"-field being overwritten for normalizer plugins.
10 tasks
underdarknl
reviewed
Jan 14, 2023
|
Tests are failing because of an Octopoes import. Am I correct in assuming that this will fix itself once minvws/nl-kat-octopoes#38 has been merged? (I will do a functional test later today) |
Yup, this would make sense. I think the mentioned PR looks good, so if you could check them I think we can merge. |
|
Works as advertised in conjunction with minvws/nl-kat-octopoes#38. Below finding was discovered automatically from a hostname plus nmap Boefje enabled on port 80 and 443.
|
Darwinkel
previously approved these changes
Jan 16, 2023
underdarknl
previously approved these changes
Jan 16, 2023
underdarknl
changed the title
…-boefjes into feature/multipart-download
ammar92
reviewed
Jan 24, 2023
boefjes/plugins/kat_webpage_analysis/find_images_in_html/normalize.py
Outdated
Show resolved
Hide resolved
…but log them and make sure to add an ended_at and save the normalizer_meta to bytes. Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
… feature/multipart-download
underdarknl
reviewed
Jan 24, 2023
Signed-off-by: Donny Peeters <[email protected]>
underdarknl
approved these changes
Jan 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature in screenshots
The new objects found by the find_images_in_html normalizer: site images
Image is downloaded by website_analysis boefje with image/png mime type:
New normalizer running on image mime types:
New ImageMeta objects created by that normalizer: