Inactionware#99 Clear code

minjing · Feb 19, 2019 · 3748082 · 3748082
1 parent 253ad2a
commit 3748082
Show file tree

Hide file tree

Showing 13 changed files with 0 additions and 359 deletions.
diff --git a/uapi.app/src/main/java/uapi/app/internal/Application.java b/uapi.app/src/main/java/uapi/app/internal/Application.java
@@ -29,11 +29,6 @@ public class Application {
     private static final String BEHAVIOR_STARTUP            = "startUp";
     private static final String BEHAVIOR_SHUTDOWN           = "shutdown";
 
-//    private final IAnonymousAction DEFAULT_FAILURE_ACTION = (failure, ctx) -> {
-//        this._logger.error(failure.cause(), "Fail to process behavior - {}", ctx.behaviorName());
-//        return null;
-//    };
-
     private final IBehaviorFailureCall DEFAULT_FAILURE_ACTION = (failure, ctx) -> {
         this._logger.error(failure.cause(), "Fail to process behavior - {}", ctx.behaviorName());
         return null;

diff --git a/uapi.behavior.apt/src/main/java/uapi/behavior/annotation/Output.java b/uapi.behavior.apt/src/main/java/uapi/behavior/annotation/Output.java
diff --git a/uapi.behavior.apt/src/main/java/uapi/behavior/internal/ActionHandler.java b/uapi.behavior.apt/src/main/java/uapi/behavior/internal/ActionHandler.java
@@ -19,7 +19,6 @@
 import uapi.behavior.annotation.ActionDo;
 import uapi.codegen.*;
 import uapi.common.Numeric;
-import uapi.common.StringHelper;
 import uapi.rx.Looper;
 import uapi.service.IServiceHandlerHelper;
 import uapi.service.annotation.Service;
@@ -181,42 +180,6 @@ public ActionMethodMeta parseActionMethod(Element classElement) {
                 paramMetas[idx] = paramMeta;
             });
             return new ActionMethodMeta(actionMethodName, paramMetas);
-
-//            String inputType;
-//            String outputType;
-//            boolean needContext = false;
-//            if (paramElements.size() == 0) {
-//                throw new GeneralException(
-//                        "The method annotated with ActionDo must contains 1 or 2 parameters - {}::{}",
-//                        classElement.getSimpleName().toString(), actionMethodName);
-//            } else if (paramElements.size() > 2) {
-//                throw new GeneralException(
-//                        "The method annotated with ActionDo must contains more than 2 parameters - {}::{}",
-//                        classElement.getSimpleName().toString(), actionMethodName);
-//            } else {
-//                VariableElement inputParamElement = (VariableElement) paramElements.get(0);
-//                inputType = inputParamElement.asType().toString();
-//                if (paramElements.size() == 1) {
-//                    if (IExecutionContext.class.getCanonicalName().equals(inputType)) {
-//                        inputType = Type.VOID;
-//                        needContext = true;
-//                    }
-//                } else if (paramElements.size() == 2) {
-//                    VariableElement contextParamElement = (VariableElement) paramElements.get(1);
-//                    if (! IExecutionContext.class.getCanonicalName().equals(contextParamElement.asType().toString())) {
-//                        throw new GeneralException(
-//                                "The second parameter of method which annotated with ActionDo must be IExecutionContext - {}::{}",
-//                                classElement.getSimpleName().toString(), actionMethodName);
-//                    }
-//                    needContext = true;
-//                }
-//            }
-//            outputType = actionDoElement.getReturnType().toString();
-//            // convert native type to associated qualified type
-//            inputType = Type.toQType(inputType);
-//            outputType = Type.toQType(outputType);
-//
-//            return new ActionMethodMeta(inputType, outputType, actionMethodName, needContext);
         }
     }
 }
diff --git a/uapi.behavior/src/main/java/uapi/behavior/ActionOutputMeta.java b/uapi.behavior/src/main/java/uapi/behavior/ActionOutputMeta.java
@@ -81,15 +81,4 @@ public boolean equals(Object other) {
         ActionOutputMeta otherMeta = (ActionOutputMeta) other;
         return this._name.equals(otherMeta._name) || this._type.equals(otherMeta._type);
     }
-
-//    public void verifyInput(Object input) {
-//        if (! this.type().isAssignableFrom(input.getClass())) {
-//            throw BehaviorException.builder()
-//                    .errorCode(BehaviorErrors.INPUT_OUTPUT_NOT_MATCH)
-//                    .variables(new BehaviorErrors.InputOutputNotMatch()
-//                            .outputMeta(this)
-//                            .input(input))
-//                    .build();
-//        }
-//    }
 }
diff --git a/uapi.behavior/src/main/java/uapi/behavior/ActionResult.java b/uapi.behavior/src/main/java/uapi/behavior/ActionResult.java
diff --git a/uapi.behavior/src/main/java/uapi/behavior/BehaviorEvent.java b/uapi.behavior/src/main/java/uapi/behavior/BehaviorEvent.java
@@ -12,9 +12,6 @@
 import uapi.common.ArgumentChecker;
 import uapi.event.AttributedEvent;
 
-import java.util.HashMap;
-import java.util.Map;
-
 /**
  * The implementation for IBehaviorEvent interface
  */

diff --git a/uapi.behavior/src/main/java/uapi/behavior/BehaviorFailure.java b/uapi.behavior/src/main/java/uapi/behavior/BehaviorFailure.java
@@ -34,7 +34,6 @@ public BehaviorFailure(
     ) {
         ArgumentChecker.required(failureAction, "failureAction");
         ArgumentChecker.required(failureInputs, "failureInput");
-//        ArgumentChecker.required(cause, "cause");
 
         this._failureAction = failureAction;
         this._failureInputs = failureInputs;

diff --git a/uapi.behavior/src/main/java/uapi/behavior/IAnonymousAction.java b/uapi.behavior/src/main/java/uapi/behavior/IAnonymousAction.java
diff --git a/uapi.behavior/src/main/java/uapi/behavior/IBehaviorBuilder.java b/uapi.behavior/src/main/java/uapi/behavior/IBehaviorBuilder.java
@@ -1,7 +1,6 @@
 package uapi.behavior;
 
 import uapi.common.Functionals;
-import uapi.event.IEventFinishCallback;
 
 /**
  * A builder for behavior creation
@@ -83,30 +82,6 @@ public interface IBehaviorBuilder {
      */
     IBehaviorBuilder then(Class<? extends IAction> actionType, String label, Object... inputs) throws BehaviorException;
 
-    /**
-     * Set next an anonymous action when current branch condition is satisfied.
-     *
-     * @param   action
-     *          The anonymous action
-     * @return  The behavior builder self
-     * @throws  BehaviorException
-     *          Any cause when set action
-     */
-//    IBehaviorBuilder then(IAnonymousAction action) throws BehaviorException;
-
-    /**
-     * Set next an anonymous action with specific label when current branch condition is satisfied.
-     *
-     * @param   action
-     *          The anonymous action
-     * @param   label
-     *          The action/behavior label which can be used to navigate to it later
-     * @return  The behavior builder self
-     * @throws  BehaviorException
-     *          Any cause when set action
-     */
-//    IBehaviorBuilder then(IAnonymousAction action, String label) throws BehaviorException;
-
     /**
      * Set next an anonymous action which return nothing when current branch condition is satisfied.
      *
@@ -140,8 +115,6 @@ public interface IBehaviorBuilder {
      */
     IBehaviorBuilder onSuccess(IBehaviorSuccessCall action);
 
-//    IBehaviorBuilder onSuccess(ActionIdentify actionId);
-
     /**
      * Invoke the action when the behavior is executed failed
      *
@@ -151,8 +124,6 @@ public interface IBehaviorBuilder {
      */
     IBehaviorBuilder onFailure(IBehaviorFailureCall action);
 
-//    IBehaviorBuilder onFailure(ActionIdentify actionId);
-
     /**
      * Get navigator which associated with this behavior builder
      *

diff --git a/uapi.behavior/src/main/java/uapi/behavior/IExecutionContext.java b/uapi.behavior/src/main/java/uapi/behavior/IExecutionContext.java
@@ -11,8 +11,6 @@
 
 import java.util.Map;
 
-import uapi.behavior.BehaviorEvent;
-
 /**
  * Store context during execution time
  */

diff --git a/uapi.behavior/src/main/java/uapi/behavior/INavigator.java b/uapi.behavior/src/main/java/uapi/behavior/INavigator.java
@@ -12,13 +12,6 @@ public interface INavigator {
      */
     IBehaviorBuilder moveToStarting();
 
-    /**
-     * Move current cursor to previous action
-     *
-     * @return  The associated behavior builder
-     */
-//    IBehaviorBuilder moveToPrevious();
-
     /**
      * Move current cursor to specific labeled action.
      *

diff --git a/uapi.behavior/src/main/java/uapi/behavior/IResponsible.java b/uapi.behavior/src/main/java/uapi/behavior/IResponsible.java
@@ -57,20 +57,6 @@ IBehaviorBuilder newBehavior(
             Class<? extends IEvent> eventType,
             String topic) throws BehaviorException;
 
-    /**
-     * Create new behavior builder on specific input data type which can handled by the behavior.
-     *
-     * @param   types
-     *          The data types which can be handled by the behavior
-     * @return  The behavior builder
-     * @throws  BehaviorException
-     *          The name is used in other behavior, error code see {@link BehaviorErrors.BEHAVIOR_ID_IS_USED}
-     */
-//    IBehaviorBuilder newBehavior(
-//            String name,
-//            Class<?> type
-//    ) throws BehaviorException;
-
     IBehaviorBuilder newBehavior(
             String name,
             Class<?> ... types
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,8 +11,6 @@ @@
     import java.util.Map;
-    import uapi.behavior.BehaviorEvent;
     /**
      * Store context during execution time
      */
@@ Expand Down @@